Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pandas 1.2.0 #1286

Merged
merged 13 commits into from
Dec 30, 2020
Merged

Fix for pandas 1.2.0 #1286

merged 13 commits into from
Dec 30, 2020

Conversation

thehomebrewnerd
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd commented Dec 28, 2020

Fix for pandas 1.2.0

pandas 1.2.0 included a new warning which caused unit test failures in Featuretools. This PR removes the usage of .ravel which was causing a warning to be raised, when none were expected in the tests.

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #1286 (6530659) into main (477c249) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1286   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         134      134           
  Lines       14456    14456           
=======================================
  Hits        14220    14220           
  Misses        236      236           
Impacted Files Coverage Δ
...s/computational_backends/feature_set_calculator.py 98.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 477c249...6530659. Read the comment docs.

@thehomebrewnerd thehomebrewnerd changed the title Restrict Pandas Version Temporarily Fix for pandas 1.2.0 Dec 28, 2020
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thehomebrewnerd thehomebrewnerd merged commit 0baadcb into main Dec 30, 2020
@thehomebrewnerd thehomebrewnerd deleted the pin-pandas branch December 30, 2020 16:54
@rwedge rwedge mentioned this pull request Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants