Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1294 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 134 134
Lines 14473 14473
=======================================
Hits 14239 14239
Misses 234 234
Continue to review full report at Codecov.
|
rwedge
reviewed
Jan 4, 2021
docs/source/release_notes.rst
Outdated
Contributor
There was a problem hiding this comment.
Including the exact test name is maybe a bit too specific for a testing entry - if people want that info they can check the PR
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Non-Deterministic Dask Test
A recent update has caused some non-deterministic behavior in
test_calculate_feature_matrix::test_entities_relationshipswhen running with Dask input. This PR adds a sort operation on the output feature matrices to make sure they are always ordered the same before the equality assertion.The source of the non-determinism was not established, but was first discovered due to an automated dependency update check when tqdm was updated, although that does not seem to be the source of the problem.