Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Non-Deterministic Dask Test #1294

Merged
merged 6 commits into from Jan 4, 2021
Merged

Fix Non-Deterministic Dask Test #1294

merged 6 commits into from Jan 4, 2021

Conversation

thehomebrewnerd
Copy link
Contributor

Fix Non-Deterministic Dask Test

A recent update has caused some non-deterministic behavior in test_calculate_feature_matrix::test_entities_relationships when running with Dask input. This PR adds a sort operation on the output feature matrices to make sure they are always ordered the same before the equality assertion.

The source of the non-determinism was not established, but was first discovered due to an automated dependency update check when tqdm was updated, although that does not seem to be the source of the problem.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #1294 (ba9bc84) into main (1cc759a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1294   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         134      134           
  Lines       14473    14473           
=======================================
  Hits        14239    14239           
  Misses        234      234           
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 99.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc759a...ba9bc84. Read the comment docs.

* Enhancements
* Fixes
* Changes
* Documentation Changes
* Testing Changes
* Fix non-deterministic Dask test ``test_calculate_feature_matrix::test_entities_relationships`` (:pr:`1294`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the exact test name is maybe a bit too specific for a testing entry - if people want that info they can check the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thehomebrewnerd thehomebrewnerd merged commit ebf1760 into main Jan 4, 2021
@thehomebrewnerd thehomebrewnerd deleted the fix-dask-test branch January 4, 2021 16:26
@rwedge rwedge mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants