Skip to content

Unpin graphviz on windows ci tests - #1296

Merged
rwedge merged 2 commits into
mainfrom
unpin-graphviz-windows
Jan 6, 2021
Merged

rwedge merged 2 commits into
mainfrom
unpin-graphviz-windows

Conversation

@rwedge

@rwedge rwedge commented Jan 6, 2021 •

Copy link
Copy Markdown
Contributor

Fixes #1289
Unpin python-graphviz package on windows unit tests now that issue with latest release has been resolved

@codecov

codecov Bot commented Jan 6, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #1296 (bba2433) into main (aaccd62) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1296   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         134      134           
  Lines       14473    14473           
=======================================
  Hits        14239    14239           
  Misses        234      234           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaccd62...bba2433. Read the comment docs.

@rwedge
rwedge requested a review from thehomebrewnerd January 6, 2021 22:24

@thehomebrewnerd thehomebrewnerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rwedge
rwedge merged commit 3da2a76 into main Jan 6, 2021
@rwedge
rwedge deleted the unpin-graphviz-windows branch January 6, 2021 22:36
VibhuJawa added a commit to VibhuJawa/featuretools that referenced this pull request Jan 12, 2021
* inital experiments with negate

* inital working with agg

* added working agg stats

* working+verified with agg columns

* fixed fillna mistake

* added back comment

* decreased inconsitentcies

* 2 percent incorrect left

* Verified correctness across 2000 columns

* Code cleanup

* more cleanup

* Added more primitives

* 10/12 tests working

* working test_add_last_time_indexes

* working with most tests

* removed test_debug.py

* Major code cleanup

* passes most tests

* Create nvidia_featuretools_copyright.md

Adding Nvidia license.

* Update and rename nvidia_featuretools_copyright.md to nvidia_featuretools_license.md

* Unpin graphviz on windows ci tests (alteryx#1296)

* Unpin graphviz on windows ci tests

* Update release_notes.rst

* fixed test failures

* remove unused cudf import from test_dfs_method.py

* add cudf computational backend

* Update latest_dependencies.txt (alteryx#1300)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [WIP]Add support for approx parameter  with cutoff as pandas dataframes  (#1)

* working approx implementation with cutoff as a pandas dataframe.

* style fix for comment at line :463

Co-authored-by: Roy Wedge <roy.wedge@alteryx.com>
Co-authored-by: machineFL <49695056+machineFL@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@rwedge rwedge mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unpin python-graphviz install for Windows CI tests

2 participants