Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom primitive creation functions #13

Merged
merged 12 commits into from Oct 12, 2017
Merged

Custom primitive creation functions #13

merged 12 commits into from Oct 12, 2017

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Oct 11, 2017

Added two functions, make_trans_primitive and make_agg_primitive. Given a function to apply to input features, list of allowed input feature types, and variable type of the resulting feature, these functions will create a new primitive that can be used with DFS.

@@ -1,4 +1,4 @@
import pickle
import cloudpickle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to add cloudpickle to requirements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@codecov-io
Copy link

Codecov Report

Merging #13 into master will increase coverage by 0.42%.
The diff coverage is 95.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   86.44%   86.86%   +0.42%     
==========================================
  Files          73       73              
  Lines        6549     6778     +229     
==========================================
+ Hits         5661     5888     +227     
- Misses        888      890       +2
Impacted Files Coverage Δ
featuretools/demo/mock_customer.py 14.7% <ø> (ø) ⬆️
featuretools/utils/pickle_utils.py 75.86% <100%> (ø) ⬆️
featuretools/primitives/aggregation_primitives.py 92.1% <100%> (+0.85%) ⬆️
...ols/tests/feature_function_tests/test_agg_feats.py 98.35% <100%> (+0.75%) ⬆️
featuretools/primitives/utils.py 93.15% <100%> (+1.48%) ⬆️
featuretools/primitives/primitive_base.py 76.94% <79.16%> (ø) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 92.09% <88.88%> (+0.13%) ⬆️
...turetools/primitives/aggregation_primitive_base.py 95.45% <92.59%> (-4.55%) ⬇️
featuretools/primitives/transform_primitive.py 96.78% <94.44%> (-0.51%) ⬇️
.../feature_function_tests/test_transform_features.py 85.15% <95.65%> (+0.89%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aaab45...5ecf272. Read the comment docs.

@kmax12 kmax12 merged commit fee8653 into master Oct 12, 2017
@kmax12 kmax12 deleted the make_primitives branch December 20, 2017 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants