Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary pytest.skip calls #1320

merged 2 commits into from Jan 27, 2021

Remove unnecessary pytest.skip calls #1320

merged 2 commits into from Jan 27, 2021


Copy link

@thehomebrewnerd thehomebrewnerd commented Jan 27, 2021

Remove unnecessary pytest.skip calls

Removes multiple unnecessary calls to pytest.skip which was being used to skip Koalas tests on Windows. However, the current test environment is not installing Windows, so the tests were being skipped anyway due to a pytest.importorskip call that is in place.

Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #1320 (f4c44fd) into main (6f7cead) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1320      +/-   ##
+ Coverage   98.38%   98.51%   +0.12%     
  Files         135      135              
  Lines       14496    14452      -44     
- Hits        14262    14237      -25     
+ Misses        234      215      -19     
Impacted Files Coverage Δ
featuretools/computational_backends/ 95.54% <ø> (ø)
...mputational_backend/ 100.00% <ø> (+0.36%) ⬆️
featuretools/tests/ 100.00% <ø> (+3.40%) ⬆️
featuretools/tests/entityset_tests/ 100.00% <ø> (+1.28%) ⬆️
...uretools/tests/entityset_tests/ 100.00% <ø> (+0.59%) ⬆️
...eaturetools/tests/entityset_tests/ 100.00% <ø> (+1.63%) ⬆️
...ols/tests/synthesis/ 99.29% <ø> (+0.13%) ⬆️
featuretools/utils/ 92.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4983033...f4c44fd. Read the comment docs.

@thehomebrewnerd thehomebrewnerd changed the title Testing Koalas on Windows [DO NOT MERGE] Remove unnecessary pytest.skip calls Jan 27, 2021
@thehomebrewnerd thehomebrewnerd self-assigned this Jan 27, 2021
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thehomebrewnerd thehomebrewnerd merged commit 2e0c97a into main Jan 27, 2021
@thehomebrewnerd thehomebrewnerd deleted the win-test branch January 27, 2021 23:24
@rwedge rwedge mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants