Remove unnecessary pytest.skip calls - #1320
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1320 +/- ##
==========================================
+ Coverage 98.38% 98.51% +0.12%
==========================================
Files 135 135
Lines 14496 14452 -44
==========================================
- Hits 14262 14237 -25
+ Misses 234 215 -19
Continue to review full report at Codecov.
|
pytest.skip calls
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary
pytest.skipcallsRemoves multiple unnecessary calls to pytest.skip which was being used to skip Koalas tests on Windows. However, the current test environment is not installing Windows, so the tests were being skipped anyway due to a
pytest.importorskipcall that is in place.