Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update twitter links in docs #1322

Merged
merged 4 commits into from Jan 28, 2021
Merged

Update twitter links in docs #1322

merged 4 commits into from Jan 28, 2021

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jan 27, 2021

@gsheni gsheni requested a review from rwedge January 27, 2021 23:35
@gsheni gsheni self-assigned this Jan 27, 2021
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #1322 (643aa4d) into main (6f7cead) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
+ Coverage   98.38%   98.51%   +0.12%     
==========================================
  Files         135      135              
  Lines       14496    14452      -44     
==========================================
- Hits        14262    14237      -25     
+ Misses        234      215      -19     
Impacted Files Coverage Δ
featuretools/computational_backends/utils.py 95.54% <ø> (ø)
...mputational_backend/test_feature_set_calculator.py 100.00% <ø> (+0.36%) ⬆️
featuretools/tests/conftest.py 100.00% <ø> (+3.40%) ⬆️
featuretools/tests/entityset_tests/test_es.py 100.00% <ø> (+1.28%) ⬆️
...uretools/tests/entityset_tests/test_es_metadata.py 100.00% <ø> (+0.59%) ⬆️
...eaturetools/tests/entityset_tests/test_plotting.py 100.00% <ø> (+1.63%) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.29% <ø> (+0.13%) ⬆️
featuretools/utils/plot_utils.py 92.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e0c97a...643aa4d. Read the comment docs.

@rwedge
Copy link
Contributor

rwedge commented Jan 28, 2021

There's a second twitter URL in the footer, can you update that as well?

@gsheni
Copy link
Contributor Author

gsheni commented Jan 28, 2021

@rwedge Fixed. Here is a preview:
https://featuretools.alteryx.com/en/add_gh_twitter_link/

@rwedge
Copy link
Contributor

rwedge commented Jan 28, 2021

Looks good, add yourself to the contributor list!

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit 02d960f into main Jan 28, 2021
@gsheni gsheni deleted the add_gh_twitter_link branch January 28, 2021 16:23
@rwedge rwedge mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update twitter links in docs
2 participants