Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Entityset.__eq__ bug and test coverage #1323

Merged
merged 8 commits into from Jan 29, 2021
Merged

Conversation

thehomebrewnerd
Copy link
Collaborator

@thehomebrewnerd thehomebrewnerd commented Jan 28, 2021

Fix EntitySet.__eq__ bug and test coverage

Fixes #1281

Fixes a bug in EntitySet.__eq__ where relationships were not being compared properly between self and other. Also adds a new test to cover lines in __eq__ and __ne__ that were previously uncovered

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1323 (5256b56) into main (6f7cead) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   98.38%   98.58%   +0.19%     
==========================================
  Files         135      135              
  Lines       14496    14516      +20     
==========================================
+ Hits        14262    14310      +48     
+ Misses        234      206      -28     
Impacted Files Coverage Δ
featuretools/computational_backends/utils.py 95.54% <ø> (ø)
...mputational_backend/test_feature_set_calculator.py 100.00% <ø> (+0.36%) ⬆️
...uretools/tests/entityset_tests/test_es_metadata.py 100.00% <ø> (+0.59%) ⬆️
...eaturetools/tests/entityset_tests/test_plotting.py 100.00% <ø> (+1.63%) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.29% <ø> (+0.13%) ⬆️
featuretools/utils/plot_utils.py 92.00% <ø> (ø)
...s/computational_backends/feature_set_calculator.py 98.70% <100.00%> (+0.01%) ⬆️
featuretools/entityset/entityset.py 98.77% <100.00%> (+0.81%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.44% <100.00%> (+<0.01%) ⬆️
featuretools/tests/conftest.py 100.00% <100.00%> (+3.40%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5450641...5256b56. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thehomebrewnerd thehomebrewnerd merged commit 373b54c into main Jan 29, 2021
@thehomebrewnerd thehomebrewnerd deleted the entityset-eq branch January 29, 2021 18:08
@rwedge rwedge mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EntitySet.__eq__ bug fix and test coverage improvement
2 participants