Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about dropping python 3.6 in the future #1344

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Feb 25, 2021

When featuretools is imported, checks to see if the environment is python 3.6. If so, warns that Featuretools will be dropping python 3.6 support in an upcoming release.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1344 (8217615) into main (6f7cead) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1344      +/-   ##
==========================================
+ Coverage   98.38%   98.58%   +0.19%     
==========================================
  Files         135      135              
  Lines       14496    14541      +45     
==========================================
+ Hits        14262    14335      +73     
+ Misses        234      206      -28     
Impacted Files Coverage Δ
featuretools/computational_backends/utils.py 95.54% <ø> (ø)
...mputational_backend/test_feature_set_calculator.py 100.00% <ø> (+0.36%) ⬆️
...uretools/tests/entityset_tests/test_es_metadata.py 100.00% <ø> (+0.59%) ⬆️
...eaturetools/tests/entityset_tests/test_plotting.py 100.00% <ø> (+1.63%) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.29% <ø> (+0.13%) ⬆️
featuretools/utils/plot_utils.py 92.00% <ø> (ø)
featuretools/__init__.py 84.21% <100.00%> (+1.35%) ⬆️
...s/computational_backends/feature_set_calculator.py 98.70% <100.00%> (+0.01%) ⬆️
featuretools/entityset/entityset.py 98.77% <100.00%> (+0.81%) ⬆️
featuretools/primitives/utils.py 99.20% <100.00%> (+0.09%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8506164...34da66f. Read the comment docs.

@rwedge rwedge marked this pull request as ready for review February 26, 2021 15:17
@rwedge rwedge requested a review from gsheni February 26, 2021 15:21
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@rwedge rwedge merged commit 2178118 into main Feb 26, 2021
@rwedge rwedge deleted the warn-dropping-36 branch February 26, 2021 15:49
@gsheni gsheni mentioned this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants