Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Koalas 1.7.0 #1351

merged 2 commits into from Mar 8, 2021

Fixes for Koalas 1.7.0 #1351

merged 2 commits into from Mar 8, 2021


Copy link

Pull Request Description

This PR implements fixes for two issues for breaking changes that occurred with Koalas 1.7.0:

  • Update to make sure datetime64[ns] is used properly in place of datetime
  • Add a pytest.skip to a test that was failing due to Koalas throwing additional warnings. This is similar to the approach used in another test, but could warrant further investigation to see if the extra Koalas warning can be eliminated.

Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #1351 (201195c) into main (ac2168d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1351   +/-   ##
  Coverage   98.58%   98.58%           
  Files         135      135           
  Lines       14541    14543    +2     
+ Hits        14335    14337    +2     
  Misses        206      206           
Impacted Files Coverage Δ
featuretools/tests/synthesis/ 100.00% <100.00%> (ø)
featuretools/variable_types/ 98.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2168d...72e2f42. Read the comment docs.

Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thehomebrewnerd thehomebrewnerd merged commit 7e9e96f into main Mar 8, 2021
20 checks passed
@thehomebrewnerd thehomebrewnerd deleted the koalas-fix branch March 8, 2021 19:14
@rwedge rwedge mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants