Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict smart-open version #1372

merged 3 commits into from Mar 30, 2021

Restrict smart-open version #1372

merged 3 commits into from Mar 30, 2021


Copy link

Restrict smart-open version

Some serialization test fail with the new smart-open version 5.0.0. This PR restricts smart-open to <5.0.0 while this is being investigated.

gsheni previously approved these changes Mar 30, 2021
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #1372 (ce2b29d) into main (4986c81) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1372   +/-   ##
  Coverage   98.58%   98.58%           
  Files         135      135           
  Lines       14543    14543           
  Hits        14337    14337           
  Misses        206      206           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c3ba3...ce2b29d. Read the comment docs.

@thehomebrewnerd thehomebrewnerd merged commit 8311c6c into main Mar 30, 2021
22 checks passed
@thehomebrewnerd thehomebrewnerd deleted the restrict-smart-open branch March 30, 2021 14:08
@rwedge rwedge mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants