Restrict smart-open version #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
previously approved these changes
Mar 30, 2021
gsheni
approved these changes
Mar 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #1372 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 135 135
Lines 14543 14543
=======================================
Hits 14337 14337
Misses 206 206 Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict smart-open version
Some serialization test fail with the new smart-open version 5.0.0. This PR restricts smart-open to
<5.0.0while this is being investigated.