Skip to content

Updates to work with smart-open 5.0.0 - #1376

Merged
thehomebrewnerd merged 3 commits into
mainfrom
smartopen-bug
Mar 31, 2021
Merged

thehomebrewnerd merged 3 commits into
mainfrom
smartopen-bug

Conversation

@thehomebrewnerd

Copy link
Copy Markdown
Contributor

Updates to work with smart-open 5.0.0

Closes #1373

@rwedge

rwedge commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

We should also update the SMART_OPEN_ERR_MSG to include 5.0 or higher in the install command

@codecov

codecov Bot commented Mar 31, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #1376 (a21b140) into main (8311c6c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files         135      135           
  Lines       14543    14546    +3     
=======================================
+ Hits        14337    14340    +3     
  Misses        206      206           
Impacted Files Coverage Δ
featuretools/utils/s3_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8311c6c...a21b140. Read the comment docs.

@thehomebrewnerd

Copy link
Copy Markdown
Contributor Author

We should also update the SMART_OPEN_ERR_MSG to include 5.0 or higher in the install command

Updated.

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@thehomebrewnerd
thehomebrewnerd merged commit c017919 into main Mar 31, 2021
@thehomebrewnerd
thehomebrewnerd deleted the smartopen-bug branch March 31, 2021 21:52
@rwedge rwedge mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

smart-open version 5.0.0 breaks serialization tests

2 participants