Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to work with smart-open 5.0.0 #1376

Merged
merged 3 commits into from Mar 31, 2021
Merged

Updates to work with smart-open 5.0.0 #1376

merged 3 commits into from Mar 31, 2021

Conversation

thehomebrewnerd
Copy link
Collaborator

Updates to work with smart-open 5.0.0

Closes #1373

@gsheni gsheni requested a review from rwedge March 31, 2021 21:22
@rwedge
Copy link
Contributor

rwedge commented Mar 31, 2021

We should also update the SMART_OPEN_ERR_MSG to include 5.0 or higher in the install command

@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited

Codecov Report

Merging #1376 (a21b140) into main (8311c6c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files         135      135           
  Lines       14543    14546    +3     
=======================================
+ Hits        14337    14340    +3     
  Misses        206      206
Impacted Files Coverage Δ
featuretools/utils/s3_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8311c6c...a21b140. Read the comment docs.

@thehomebrewnerd
Copy link
Collaborator Author

We should also update the SMART_OPEN_ERR_MSG to include 5.0 or higher in the install command

Updated.

rwedge
rwedge approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@thehomebrewnerd thehomebrewnerd merged commit c017919 into main Mar 31, 2021
@thehomebrewnerd thehomebrewnerd deleted the smartopen-bug branch March 31, 2021 21:52
@rwedge rwedge mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@thehomebrewnerd thehomebrewnerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

smart-open version 5.0.0 breaks serialization tests
2 participants
@thehomebrewnerd @rwedge