Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable fail-fast behavior on CI tests #1386

Merged
merged 4 commits into from Apr 5, 2021
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Apr 2, 2021

Disable the fail-fast strategy on our unit tests, which is cancelling jobs if a job in the same test matrix has failed (currently if the py38 optional unit tests fail, the py37 and py36 optionals will be cancelled). I'd prefer to have the tests continue to so we'll know if there are issues with the other environments we're testing on.

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #1386 (6cd4ca4) into main (ca05bee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1386   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files         135      135           
  Lines       14546    14578   +32     
=======================================
+ Hits        14340    14372   +32     
  Misses        206      206           
Impacted Files Coverage Δ
featuretools/entityset/deserialize.py 100.00% <100.00%> (ø)
featuretools/tests/conftest.py 100.00% <100.00%> (ø)
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)
...s/tests/primitive_tests/test_transform_features.py 98.80% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a1f56...6cd4ca4. Read the comment docs.

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rwedge rwedge merged commit f3fbf64 into main Apr 5, 2021
@rwedge rwedge deleted the gh-action-matrix-slow-fail branch April 5, 2021 18:09
@rwedge rwedge mentioned this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants