-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No EntitySet required in loading/saving features #141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 92.21% 91.37% -0.84%
==========================================
Files 72 72
Lines 7707 7722 +15
==========================================
- Hits 7107 7056 -51
- Misses 600 666 +66
Continue to review full report at Codecov.
|
featuretools/entityset/entityset.py
Outdated
r.entityset = new_entityset | ||
return new_entityset | ||
|
||
# TODO make these private |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this todo
featuretools/entityset/entityset.py
Outdated
|
||
@property | ||
def metadata(self): | ||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a docstring to the first line of this so it shows up properly in the documentation?
return new_v | ||
|
||
@property | ||
def is_metadata(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add docstring
By creating an
EntitySet.metadata
object, this removes the need to remove (and thus place back upon loading) the references to the EntitySet inside of a list of features before saving to disk. This also eliminates the need for any fanciness before/after pickling.This also means that calculate_feature_matrix needs an explicit
EntitySet
passed in, rather than being able to access the referencedEntitySet
from the feature objects.The new API is like this: