Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name attribute to EmailAddressToDomain #1543

Merged
merged 5 commits into from Jul 22, 2021
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Jul 21, 2021

Set name attribute for EmailAddressToDomain primitive and update init_and_name tests to confirm each primitive has a name defined

Fixes #1542

@gsheni gsheni changed the title Rw email to domain fix Add name attribute to EmailAddressToDomain Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #1543 (31a4126) into main (94f561b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1543   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files         140      140           
  Lines       14990    15003   +13     
=======================================
+ Hits        14778    14791   +13     
  Misses        212      212           
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100.00% <100.00%> (ø)
...aturetools/tests/primitive_tests/test_agg_feats.py 98.40% <100.00%> (+0.02%) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.81% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f561b...31a4126. Read the comment docs.

@@ -853,6 +853,7 @@ class EmailAddressToDomain(TransformPrimitive):
>>> email_address_to_domain(['name@gmail.com', 'name@featuretools.com']).tolist()
['gmail.com', 'featuretools.com']
"""
name = "email_address_to_domain"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without testing - this makes me wonder if we also need to add the compatibility attribute to this and the other new primitives? Are they all compatible with all three dataframe libraries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now they should inherit pandas compatibility from PrimitiveBase

made #1549 to track compatibility testing

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI passes.

@rwedge rwedge merged commit f724977 into main Jul 22, 2021
@rwedge rwedge deleted the rw-email-to-domain-fix branch July 22, 2021 19:47
@davesque davesque mentioned this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run EmailAddressToDomain in DFS
2 participants