Ensure relationship variables are the same underlying dtype #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 92.59% 92.62% +0.03%
==========================================
Files 72 72
Lines 7722 7729 +7
==========================================
+ Hits 7150 7159 +9
+ Misses 572 570 -2
Continue to review full report at Codecov.
|
rwedge
reviewed
May 24, 2018
| if ((is_object_dtype(parent_e.df[parent_v]) or | ||
| is_string_dtype(parent_e.df[parent_v])) and | ||
| is_numeric_dtype(child_e.df[child_v])): | ||
| parent_e.df[parent_v] = pd.to_numeric(self[parent_e.id].df[parent_v]) |
There was a problem hiding this comment.
The self[parent_e.id] here can be changed to parent_e.df
rwedge
reviewed
May 24, 2018
| target_entity="sessions", | ||
| agg_primitives=["mean", "sum", "mode"], | ||
| trans_primitives=["month", "hour"], | ||
| max_depth=2) |
There was a problem hiding this comment.
A little weird that this test has no assertions. Maybe assert that the normalize successfully converted both parent and child values to matching types? Or maybe the test should go in test_es:test_add_relationship_converts_types
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a parent entity has an index with integer data, and the linking variable in the child has object/string data, this will convert the child variable to integers. This is necessary for the new version of pandas (0.23), because merges on mixed dtypes are not allowed.