Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional reviewers to min and latest dependency checker #1562

merged 6 commits into from Jul 27, 2021


Copy link

@gsheni gsheni commented Jul 27, 2021

@gsheni gsheni self-assigned this Jul 27, 2021
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1562 (c72ebea) into main (e9d036b) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
- Coverage   98.58%   98.53%   -0.06%     
  Files         140      140              
  Lines       15003    15003              
- Hits        14791    14783       -8     
- Misses        212      220       +8     
Impacted Files Coverage Δ
...computational_backends/ 98.52% <0.00%> (-0.89%) ⬇️
...utational_backend/ 98.89% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d036b...c72ebea. Read the comment docs.

Copy link

rwedge commented Jul 27, 2021

to test, could we change the github action to happen on push to that branch?

Copy link
Member Author

gsheni commented Jul 27, 2021

@rwedge No, we can't. The PR won't be generated on push because there won't be a diff with main

Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@gsheni gsheni merged commit 5e2ec26 into main Jul 27, 2021
@gsheni gsheni deleted the fix_dep_checker branch July 27, 2021 20:16
@simha104 simha104 mentioned this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants