Remove list of times as on option for cutoff_time
in calculate_feature_matrix
#165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a list of times for
cutoff_time
was creating some unexpected behavior if there wasn't aninstance_ids
list of the same length. Some examples:This calculates features for instance 0 at time 0, instance 1 at time 1, and doesn't calculate features for instance 2.
This calculates features for instance 0 at time 0, instance 1 at time 1, and not use time 2.
This would calculate features for the first instance in the entity's dataframe at time 0 and calculate features for the second instance in the entity's dataframe at time 1.
While requiring a list of instance_ids with the same length as the list of cutoff times is one way to resolve this issue, equal length lists of instances and times can easily be represented in DataFrame format and would leave one less input case to handle.