-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove variable stats #171
Conversation
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 92.95% 93.02% +0.07%
==========================================
Files 70 68 -2
Lines 7539 7345 -194
==========================================
- Hits 7008 6833 -175
+ Misses 531 512 -19
Continue to review full report at Codecov.
|
# assert e['boolean_with_nan'].num_true == 1 | ||
# assert e['boolean_with_nan'].num_false == 1 | ||
|
||
|
||
def test_column_funcs(entityset): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test can be deleted now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see that we test the stuff in this function anywhere else, so I'll keep it to be safe. I did rename it though since it no longer tests the column functions
Currently, entity sets calculate and store statistics about the variables in them. This was previously used internally by DFS, but is no longer needed. To clean up the code, all references to calculating variable statistics inside of Featuretools have been removed.