Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove variable stats #171

Merged
merged 4 commits into from Jun 20, 2018
Merged

Remove variable stats #171

merged 4 commits into from Jun 20, 2018

Conversation

kmax12
Copy link
Contributor

@kmax12 kmax12 commented Jun 19, 2018

Currently, entity sets calculate and store statistics about the variables in them. This was previously used internally by DFS, but is no longer needed. To clean up the code, all references to calculating variable statistics inside of Featuretools have been removed.

@kmax12 kmax12 changed the title Remove variable stats [WIP] Remove variable stats Jun 19, 2018
@kmax12 kmax12 requested a review from rwedge June 19, 2018 19:37
@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #171 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   92.95%   93.02%   +0.07%     
==========================================
  Files          70       68       -2     
  Lines        7539     7345     -194     
==========================================
- Hits         7008     6833     -175     
+ Misses        531      512      -19
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 92.57% <ø> (-0.31%) ⬇️
featuretools/variable_types/variable.py 90.1% <ø> (-1.56%) ⬇️
...ols/tests/feature_function_tests/test_agg_feats.py 98.52% <ø> (ø) ⬆️
featuretools/entityset/entity.py 87.24% <ø> (+1.53%) ⬆️
featuretools/tests/entityset_tests/test_es.py 99.75% <100%> (-0.02%) ⬇️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.32% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98cfd55...63ab80b. Read the comment docs.

# assert e['boolean_with_nan'].num_true == 1
# assert e['boolean_with_nan'].num_false == 1


def test_column_funcs(entityset):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test can be deleted now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that we test the stuff in this function anywhere else, so I'll keep it to be safe. I did rename it though since it no longer tests the column functions

@kmax12 kmax12 changed the title [WIP] Remove variable stats Remove variable stats Jun 20, 2018
@kmax12 kmax12 merged commit 3439827 into master Jun 20, 2018
@rwedge rwedge mentioned this pull request Jun 22, 2018
@kmax12 kmax12 deleted the remove-variable-stats branch August 15, 2018 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants