Skip to content

Add notebook cleaner#1719

Merged
bchen1116 merged 5 commits intomainfrom
bc_add_notebook_standardizer
Sep 23, 2021
Merged

Add notebook cleaner#1719
bchen1116 merged 5 commits intomainfrom
bc_add_notebook_standardizer

Conversation

@bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Sep 23, 2021

Remove executed output of notebooks

git status

Example changes:
Pasted Graphic 10
diff --git adocssourceindex ipynb bdocssourceindex ipynb

Lint:
make lint

Lint-fix:
make lint-fix

Remaining diff:
index 3fd8d6d 0dla8ab 100644

NOTE: We see that the python version changes to my local version, and the id values for the cells are removed. The removal of IDs don't seem to be detrimental for anything, and there is no set python version, so these changes should be fine.

Added support of removing last cell if it is empty, which can be seen here

@bchen1116 bchen1116 self-assigned this Sep 23, 2021
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #1719 (e9a1729) into main (3500843) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1719   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files         138      138           
  Lines       15336    15336           
=======================================
  Hits        15133    15133           
  Misses        203      203           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3500843...e9a1729. Read the comment docs.

bchen1116 and others added 2 commits September 23, 2021 15:33
Co-authored-by: Roy Wedge <roy.wedge@alteryx.com>
@bchen1116 bchen1116 requested a review from rwedge September 23, 2021 19:55
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bchen1116 bchen1116 merged commit 9d28f1b into main Sep 23, 2021
@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 12, 2021
@rwedge rwedge deleted the bc_add_notebook_standardizer branch March 24, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants