Full coverage for EntitySet.__eq__ method#1725
Merged
rwedge merged 4 commits intoalteryx:mainfrom Sep 29, 2021
Merged
Conversation
Contributor
|
@HenryRocha Thanks for the contribution. Can you update your branch with the latest from git remote add upstream https://github.com/alteryx/featuretools
git fetch upstream
git merge upstream/main |
Codecov Report
@@ Coverage Diff @@
## main #1725 +/- ##
==========================================
+ Coverage 98.61% 98.69% +0.08%
==========================================
Files 138 138
Lines 15336 15353 +17
==========================================
+ Hits 15123 15153 +30
+ Misses 213 200 -13
Continue to review full report at Codecov.
|
davesque
previously approved these changes
Sep 28, 2021
Contributor
davesque
left a comment
There was a problem hiding this comment.
Nice, LGTM! Congrats on submitting your first issue, @HenryRocha !
rwedge
approved these changes
Sep 29, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1712