Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full coverage for EntitySet.__eq__ method #1725

Merged
merged 4 commits into from
Sep 29, 2021
Merged

Conversation

HenryRocha
Copy link
Contributor

Fixes #1712

@gsheni gsheni requested review from rwedge, thehomebrewnerd, davesque, tamargrey, tuethan1999, a team and jeff-hernandez and removed request for a team September 28, 2021 19:49
@gsheni
Copy link
Contributor

gsheni commented Sep 28, 2021

@HenryRocha Thanks for the contribution. Can you update your branch with the latest from main?

git remote add upstream https://github.com/alteryx/featuretools
git fetch upstream
git merge upstream/main

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #1725 (5a964d1) into main (ab3fd37) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
+ Coverage   98.61%   98.69%   +0.08%     
==========================================
  Files         138      138              
  Lines       15336    15353      +17     
==========================================
+ Hits        15123    15153      +30     
+ Misses        213      200      -13     
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)
featuretools/entityset/entityset.py 99.21% <0.00%> (+0.39%) ⬆️
featuretools/tests/conftest.py 100.00% <0.00%> (+0.40%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.45% <0.00%> (+0.65%) ⬆️
...computational_backends/calculate_feature_matrix.py 99.42% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3fd37...5a964d1. Read the comment docs.

davesque
davesque previously approved these changes Sep 28, 2021
Copy link
Contributor

@davesque davesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! Congrats on submitting your first issue, @HenryRocha !

@rwedge rwedge merged commit b9e43e6 into alteryx:main Sep 29, 2021
@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix codecoverage of EntitySet.__eq__ method
4 participants