Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated broken link in README for notebook demo #1728

Merged
merged 5 commits into from Sep 29, 2021

Conversation

VaishnaviNandakumar
Copy link
Contributor

@VaishnaviNandakumar VaishnaviNandakumar commented Sep 29, 2021

Pull Request Description

  • Small update in ReadMe for the broken link in Notebook Demo.

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2021

CLA assistant check
All committers have signed the CLA.

README.md Outdated
@@ -81,7 +81,7 @@ Featuretools contains many [different types of built-in primitives](https://prim
## Demos
**Predict Next Purchase**

[Repository](https://github.com/Featuretools/predict_next_purchase/) | [Notebook](https://github.com/Featuretools/predict_next_purchase/blob/main/Tutorial.ipynb)
[Repository](https://github.com/Featuretools/predict_next_purchase/) | [Notebook](https://github.com/alteryx/open_source_demos/blob/main/predict-next-purchase/Tutorial.ipynb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Repository](https://github.com/Featuretools/predict_next_purchase/) | [Notebook](https://github.com/alteryx/open_source_demos/blob/main/predict-next-purchase/Tutorial.ipynb)
[Repository](https://github.com/alteryx/open_source_demos/blob/main/predict-next-purchase/) | [Notebook](https://github.com/alteryx/open_source_demos/blob/main/predict-next-purchase/Tutorial.ipynb)

@gsheni
Copy link
Contributor

gsheni commented Sep 29, 2021

@VaishnaviNandakumar Thanks for the contribution. I had one suggestion above. Also you should update the release notes

@VaishnaviNandakumar
Copy link
Contributor Author

@gsheni Thanks for the quick response! I've made the changes according to your suggestions and updated the release notes.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #1728 (54386e5) into main (b9e43e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1728   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files         138      138           
  Lines       15361    15361           
=======================================
  Hits        15161    15161           
  Misses        200      200           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e43e6...54386e5. Read the comment docs.

@gsheni gsheni changed the title Updated broken link in ReadMe for Notebook Demo Updated broken link in README for notebook demo Sep 29, 2021
gsheni
gsheni previously approved these changes Sep 29, 2021
@gsheni gsheni merged commit a392dc4 into alteryx:main Sep 29, 2021
@gsheni
Copy link
Contributor

gsheni commented Sep 29, 2021

Congrats on your first merge request, @VaishnaviNandakumar !

@VaishnaviNandakumar
Copy link
Contributor Author

@gsheni Thank you!

@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants