Skip to content

Add nlp_primitives add-on to README, install instructions, and setup.py#1743

Merged
gsheni merged 6 commits intomainfrom
add_nlp_primitives
Oct 19, 2021
Merged

Add nlp_primitives add-on to README, install instructions, and setup.py#1743
gsheni merged 6 commits intomainfrom
add_nlp_primitives

Conversation

@gsheni
Copy link
Contributor

@gsheni gsheni commented Oct 15, 2021

  • Add nlp_primitives add-on to README, install instructions, and setup.py

@gsheni gsheni changed the title Update README.md Add nlp_primitives add-on to README, install instructions, and setup.py Oct 15, 2021
@gsheni gsheni self-assigned this Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1743 (1e4549c) into main (629324d) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
+ Coverage   98.63%   98.69%   +0.06%     
==========================================
  Files         138      138              
  Lines       15368    15368              
==========================================
+ Hits        15158    15168      +10     
+ Misses        210      200      -10     
Impacted Files Coverage Δ
featuretools/tests/conftest.py 100.00% <0.00%> (+0.40%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.45% <0.00%> (+0.65%) ⬆️
...computational_backends/calculate_feature_matrix.py 99.42% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629324d...1e4549c. Read the comment docs.

@gsheni gsheni marked this pull request as ready for review October 18, 2021 15:28
@gsheni gsheni requested a review from a team October 18, 2021 15:28
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add the nlp primitives back to the API reference like we had before, or leave them out? I don't have a strong preference, but adding them back in would make nlp_primitives required for building the docs.

@gsheni
Copy link
Contributor Author

gsheni commented Oct 19, 2021

@thehomebrewnerd I added back nlp_primitives to api_ref.
1e4549c

@gsheni gsheni merged commit bbad3f7 into main Oct 19, 2021
@gsheni gsheni deleted the add_nlp_primitives branch October 19, 2021 16:01
@rwedge rwedge mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants