Change name of date_of_birth (column name) to birthday in mock dataset by ridicolos · Pull Request #1754 · alteryx/featuretools

ridicolos · 2021-10-25T22:31:14Z

Change name of date_of_birth (column name) to birthday
Fixes Change name of date_of_birth to birthday #1697

CLAassistant · 2021-10-25T22:31:18Z

All committers have signed the CLA.

gsheni · 2021-10-26T19:49:36Z

Thanks for the contribution @ridicolos!

ridicolos · 2021-10-26T20:54:53Z

@gsheni could you maybe explain why so much of these test just failed with the changes I did? I am a little bit confused on what happens here?

What I did find, which could explian some of the errors, is that the tests use csv-files from s3 where the column-name is still set to date_of_birth. You can check it out here: https://featuretools-static.s3.amazonaws.com/test_ecommerce/customers.csv

Do I even have an ability to change this?

thehomebrewnerd · 2021-10-27T15:09:02Z

Do I even have an ability to change this?

@ridicolos I can help you with updating the S3 files when the time comes. In the meantime, there are a couple additional updates that we need to make first. I will comment on the code in the appropriate places.

Namely, we do not want to change any references to the Woodwork semantic tag of date_of_birth.

We will look into the docs build failures separately, as that seems unrelated to your changes.

thehomebrewnerd

Overall this is looking good. There are a few places where we should leave date_of_birth in place, and I have noted those.

thehomebrewnerd · 2021-10-27T15:10:13Z

   "metadata": {},
   "source": [
-    "Above we see the semantic tags that are defined within Woodwork. These tags inform how Featuretools is able to interpret data, an example of which can be seen in the `Age` primitive, which requires that the `date_of_birth` semantic tag be present on a column.\n",
+    "Above we see the semantic tags that are defined within Woodwork. These tags inform how Featuretools is able to interpret data, an example of which can be seen in the `Age` primitive, which requires that the `birthday` semantic tag be present on a column.\n",


Do not change here, we should leave the Woodwork tag as date_of_birth.

fixed with 315dac2

thehomebrewnerd · 2021-10-27T15:10:23Z

+    "Above we see the semantic tags that are defined within Woodwork. These tags inform how Featuretools is able to interpret data, an example of which can be seen in the `Age` primitive, which requires that the `birthday` semantic tag be present on a column.\n",
    "\n",
-    "The `date_of_birth` tag will not get automatically added by Woodwork, so in order for Featuretools to be able to use the `Age` primitive, the `date_of_birth` tag must be manually added to any columns to which it applies.\n",
+    "The `birthday` tag will not get automatically added by Woodwork, so in order for Featuretools to be able to use the `Age` primitive, the `birthday` tag must be manually added to any columns to which it applies.\n",


Do not change here.

fixed with 802df3d

thehomebrewnerd · 2021-10-27T15:10:57Z

    "```\n",
    "\n",
-    "Woodwork does not have a specific `DateOfBirth` logical type, but rather identifies a column as a date of birth column by specifying the logical type as `Datetime` with a semantic tag of `date_of_birth`. There is also no `Numeric` logical type in Woodwork, but rather Woodwork identifies all columns that can be used for numeric operations with the semantic tag of `numeric`. Furthermore, we know the `Age` primitive will return a floating point number, which would correspond to a Woodwork logical type of `Double`. With these items in mind, we can redefine the `Age` input types and return types with `ColumnSchema` objects as follows:\n",
+    "Woodwork does not have a specific `DateOfBirth` logical type, but rather identifies a column as a date of birth column by specifying the logical type as `Datetime` with a semantic tag of `birthday`. There is also no `Numeric` logical type in Woodwork, but rather Woodwork identifies all columns that can be used for numeric operations with the semantic tag of `numeric`. Furthermore, we know the `Age` primitive will return a floating point number, which would correspond to a Woodwork logical type of `Double`. With these items in mind, we can redefine the `Age` input types and return types with `ColumnSchema` objects as follows:\n",


Do not change here.

fixed with 315dac2

thehomebrewnerd · 2021-10-27T15:11:02Z

    "\n",
    "```python\n",
-    "input_types = [ColumnSchema(logical_type=Datetime, semantic_tags={'date_of_birth'})]\n",
+    "input_types = [ColumnSchema(logical_type=Datetime, semantic_tags={'birthday'})]\n",


Do not change here.

fixed in 315dac2

thehomebrewnerd · 2021-10-27T15:11:21Z

    "| CountryCode | ColumnSchema(logical_type=CountryCode) |\n",
    "| Datetime | ColumnSchema(logical_type=Datetime) |\n",
-    "| DateOfBirth | ColumnSchema(logical_type=Datetime, semantic_tags={'date_of_birth'}) |\n",
+    "| DateOfBirth | ColumnSchema(logical_type=Datetime, semantic_tags={'birthday'}) |\n",


Do not change here.

fixed with 315dac2

thehomebrewnerd · 2021-10-27T15:11:55Z

    """
    name = "age"
-    input_types = [ColumnSchema(logical_type=Datetime, semantic_tags={'date_of_birth'})]
+    input_types = [ColumnSchema(logical_type=Datetime, semantic_tags={'birthday'})]


Do not change here.

fixed with 315dac2

thehomebrewnerd · 2021-10-27T15:13:19Z


    customer_semantic_tags = {u'région_id': 'foreign_key',
-                              'date_of_birth': 'date_of_birth'}
+                              'birthday': 'birthday'}


This should be 'birthday': 'date_of_birth' since we just want to rename the dataframe column and not the Woodwork tag.

fixed with 315dac2

thehomebrewnerd

There is one more reference to birthday that should be changed back to date_of_birth.

thehomebrewnerd · 2021-10-27T19:44:05Z

+    "Above we see the semantic tags that are defined within Woodwork. These tags inform how Featuretools is able to interpret data, an example of which can be seen in the `Age` primitive, which requires that the `date_of_birth` semantic tag be present on a column.\n",
    "\n",
-    "The `birthday` tag will not get automatically added by Woodwork, so in order for Featuretools to be able to use the `Age` primitive, the `birthday` tag must be manually added to any columns to which it applies.\n",
+    "The `date_of_birth` tag will not get automatically added by Woodwork, so in order for Featuretools to be able to use the `Age` primitive, the `birthday` tag must be manually added to any columns to which it applies.\n",


There is another reference to the birthday tag in this sentence that needs to be changed to date_of_birth.

fixed with 5a38bc8

thehomebrewnerd · 2021-10-28T13:24:33Z

@ridicolos I have uploaded new versions of the serialized files to S3. In order for your code to find these files, you will need to make the following updates:

In tests/entityset_tests/test_serialization, update _2021_8_31 in the TEST_FILE string to `_2021_10_28:

In tests/primitive_tests/test_feature_serailization.py, update _2021_8_31 in the TEST_FILE string to `_2021_10_28:

Once you make those updates, I will trigger the test runs to make sure all the unit tests pass.

thehomebrewnerd · 2021-10-28T15:58:48Z

@ridicolos Sorry, I gave you some bad directions in my previous comment. I have updated to reflect the correct steps. Sorry for any confusion.

…e_tests/test_feature_serailization

ridicolos · 2021-10-29T22:18:29Z

@thehomebrewnerd No worrys. Haven't read the first version of your message before you changed that. 😉

I updated the TEST_FILE in both files in this commit c090cf2

codecov · 2021-11-01T18:25:17Z

Codecov Report

Merging #1754 (9d5c2aa) into main (c9ca5dd) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
- Coverage   98.70%   98.64%   -0.07%     
==========================================
  Files         138      138              
  Lines       15389    15389              
==========================================
- Hits        15190    15180      -10     
- Misses        199      209      +10

Impacted Files	Coverage Δ
...utational_backend/test_calculate_feature_matrix.py	`98.80% <ø> (-0.66%)`	⬇️
featuretools/demo/mock_customer.py	`95.23% <100.00%> (ø)`
...etools/tests/entityset_tests/test_serialization.py	`99.69% <100.00%> (ø)`
...retools/tests/primitive_tests/test_feature_base.py	`100.00% <100.00%> (ø)`
...ests/primitive_tests/test_feature_serialization.py	`99.35% <100.00%> (ø)`
...ols/tests/synthesis/test_deep_feature_synthesis.py	`99.32% <100.00%> (ø)`
featuretools/tests/testing_utils/mock_ds.py	`100.00% <100.00%> (ø)`
...computational_backends/calculate_feature_matrix.py	`98.30% <0.00%> (-0.85%)`	⬇️
featuretools/tests/conftest.py	`99.59% <0.00%> (-0.41%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ca5dd...9d5c2aa. Read the comment docs.

thehomebrewnerd

Looks good to me!

gsheni · 2021-11-01T21:10:10Z

Congrats on your first merge request, @ridicolos !

changed date_of_birth to birthday

93f3ad3

auto-assign Bot assigned ridicolos Oct 25, 2021

ridicolos mentioned this pull request Oct 25, 2021

Change name of date_of_birth to birthday #1697

Closed

thehomebrewnerd suggested changes Oct 27, 2021

View reviewed changes

ridicolos added 2 commits October 27, 2021 20:45

changed back to date_of_birth in some files

315dac2

added missing file of last commit

802df3d

thehomebrewnerd suggested changes Oct 27, 2021

View reviewed changes

changed antoher reference of brithday back to date_of_birth

5a38bc8

changed test_files in entityset_tests/test_serialization and primitiv…

c090cf2

…e_tests/test_feature_serailization

Merge branch 'main' into date_of_birth_to_birthday

1631125

gsheni changed the title ~~changed date_of_birth to birthday~~ Change name of date_of_birth (column name) to birthday Nov 1, 2021

Update release_notes.rst

1b9915b

gsheni changed the title ~~Change name of date_of_birth (column name) to birthday~~ Change name of date_of_birth (column name) to birthday in mock dataset Nov 1, 2021

Update release_notes.rst

8034d51

Merge branch 'main' into date_of_birth_to_birthday

9d5c2aa

thehomebrewnerd approved these changes Nov 1, 2021

View reviewed changes

rwedge merged commit 018c271 into alteryx:main Nov 1, 2021

This was referenced Nov 1, 2021

release Featuretools 1.1.0 #1766

Closed

v1.1.0 #1768

Merged

Uh oh!

Conversation

ridicolos commented Oct 25, 2021 • edited by gsheni Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gsheni commented Oct 26, 2021

Uh oh!

ridicolos commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thehomebrewnerd commented Oct 27, 2021

Uh oh!

thehomebrewnerd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ridicolos Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ridicolos Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ridicolos Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ridicolos Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thehomebrewnerd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thehomebrewnerd commented Oct 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thehomebrewnerd commented Oct 28, 2021

Uh oh!

ridicolos commented Oct 29, 2021

Uh oh!

codecov Bot commented Nov 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thehomebrewnerd left a comment

Choose a reason for hiding this comment

Uh oh!

gsheni commented Nov 1, 2021

Uh oh!

Reviewers

Assignees

Labels

ridicolos commented Oct 25, 2021 •

edited by gsheni

Loading

CLAassistant commented Oct 25, 2021 •

edited

Loading

ridicolos commented Oct 26, 2021 •

edited

Loading

ridicolos Oct 27, 2021 •

edited

Loading

ridicolos Oct 27, 2021 •

edited

Loading

ridicolos Oct 27, 2021 •

edited

Loading

ridicolos Oct 27, 2021 •

edited

Loading

thehomebrewnerd commented Oct 28, 2021 •

edited

Loading

codecov Bot commented Nov 1, 2021 •

edited

Loading