Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pass through columns for parallel pandas computation #1765

Merged
merged 3 commits into from Nov 1, 2021
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Oct 29, 2021

Fixes #1763

WIP for now, ideally we wouldn't need to pass schema separately. Initialize woodwork on the chunked cutoff times before sending them to the dask workers had an issue where when the worker got them they wouldn't be initialized

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #1765 (c0420a0) into main (9d9f831) will decrease coverage by 0.00%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
- Coverage   98.71%   98.70%   -0.01%     
==========================================
  Files         138      138              
  Lines       15377    15389      +12     
==========================================
+ Hits        15179    15190      +11     
- Misses        198      199       +1     
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 99.15% <75.00%> (-0.28%) ⬇️
...utational_backend/test_calculate_feature_matrix.py 99.45% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9f831...c0420a0. Read the comment docs.

@rwedge rwedge marked this pull request as ready for review November 1, 2021 16:58
@rwedge rwedge changed the title [WIP] Fix pass through columns for parallel pandas computation Fix pass through columns for parallel pandas computation Nov 1, 2021
@rwedge rwedge requested a review from a team November 1, 2021 17:08
@rwedge rwedge merged commit c9ca5dd into main Nov 1, 2021
@rwedge rwedge deleted the issue-1763 branch November 1, 2021 19:16
@rwedge rwedge mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with parallel chunk calculation and cutoff time df
2 participants