Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily min temperatures as demo dataset for time series #1777

Merged
merged 7 commits into from Nov 10, 2021

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Nov 10, 2021

@gsheni gsheni self-assigned this Nov 10, 2021
@gsheni gsheni marked this pull request as ready for review November 10, 2021 20:05
@rwedge
Copy link
Contributor

rwedge commented Nov 10, 2021

load_weather should be added to the Demo Datasets section of the API reference

@gsheni
Copy link
Member Author

gsheni commented Nov 10, 2021

@rwedge added: bd6c690

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1777 (9e85b72) into main (9d8c2cc) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1777      +/-   ##
==========================================
- Coverage   98.64%   98.55%   -0.09%     
==========================================
  Files         138      139       +1     
  Lines       15389    15419      +30     
==========================================
+ Hits        15180    15196      +16     
- Misses        209      223      +14     
Impacted Files Coverage Δ
featuretools/demo/api.py 100.00% <100.00%> (ø)
featuretools/demo/weather.py 100.00% <100.00%> (ø)
featuretools/tests/demo_tests/test_demo_data.py 100.00% <100.00%> (ø)
...utational_backend/test_calculate_feature_matrix.py 97.60% <0.00%> (-1.20%) ⬇️
...computational_backends/calculate_feature_matrix.py 97.45% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8c2cc...9e85b72. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gsheni gsheni merged commit a4146e7 into main Nov 10, 2021
@gsheni gsheni deleted the add_daily_min_temp branch November 10, 2021 21:33
@tamargrey tamargrey mentioned this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add daily min temperature demo dataset
3 participants