Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issue in Improving Computational Performance guide #1786

Merged
merged 10 commits into from
Nov 17, 2021

Conversation

thehomebrewnerd
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd commented Nov 17, 2021

Fix formatting issue in Improving Computational Performance guide

@rwedge
Copy link
Contributor

rwedge commented Nov 17, 2021

Doesn't Featuretools always create a client itself? The user can pass in a cluster but not a client

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #1786 (b8ceea4) into main (86a662d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1786   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         141      141           
  Lines       15644    15644           
=======================================
  Hits        15445    15445           
  Misses        199      199           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a662d...b8ceea4. Read the comment docs.

@thehomebrewnerd
Copy link
Contributor Author

Doesn't Featuretools always create a client itself? The user can pass in a cluster but not a client

Maybe @davesque can help with some of the details here, because I'm a little fuzzy on the details of exactly what happens when setting up a cluster/client.

What I observed during my testing with the latest code I posed in #1778 is this:

  • When I ran the example on Featuretools main, the process would hang after the feature matrix computation tasks were completed (this was with client.close() being called inside parallel_calculate_chunks)
  • When I updated FT to move the client.close() call to happen only when we create the cluster inside FT, the code did not hang and completed successfully.

I might be misunderstanding something, but that seemed to me like we were killing communication with the scheduler somehow with the client.close() call which caused things to stop working.

@thehomebrewnerd thehomebrewnerd marked this pull request as draft November 17, 2021 17:28
@thehomebrewnerd thehomebrewnerd changed the title Don't close user created Dask client Fix formatting issue in Improving Computational Performance guide Nov 17, 2021
@thehomebrewnerd thehomebrewnerd marked this pull request as ready for review November 17, 2021 19:22
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thehomebrewnerd thehomebrewnerd merged commit 024c3d8 into main Nov 17, 2021
@thehomebrewnerd thehomebrewnerd deleted the sklearn-bug branch November 17, 2021 23:36
@tamargrey tamargrey mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants