Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select low information features #18

merged 5 commits into from Oct 20, 2017


Copy link

Removes two functions: selection.select_high_variance_features and selection.select_percent_null(), and replace them with selection.remove_low_information_features().

The new function removes all features that only contain null values, or that only contain a single value.

The reason to remove these functions is that we are unsure about whether it is generally a good idea to remove these types of features. However, it is almost always a good idea to remove features that provide no information.

@bschreck bschreck changed the base branch from master to v0.1.11 October 20, 2017 16:22
Copy link

codecov-io commented Oct 20, 2017

Codecov Report

Merging #18 into v0.1.11 will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.1.11      #18      +/-   ##
+ Coverage    86.83%   87.16%   +0.32%     
  Files           73       73              
  Lines         6768     6700      -68     
- Hits          5877     5840      -37     
+ Misses         891      860      -31
Impacted Files Coverage Δ
featuretools/selection/ 100% <100%> (ø)
featuretools/selection/ 100% <100%> (ø) ⬆️
featuretools/tests/selection/ 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd66896...e7b0afa. Read the comment docs.

@kmax12 kmax12 merged commit a2b49cd into v0.1.11 Oct 20, 2017
Copy link

kmax12 commented Oct 20, 2017

looks good to me

@kmax12 kmax12 deleted the select-low-information-features branch December 20, 2017 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants