-
Notifications
You must be signed in to change notification settings - Fork 907
Add LatLong transform primitives - GeoMidpoint, IsInGeoBox, CityblockDistance #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1814 +/- ##
==========================================
+ Coverage 98.67% 98.74% +0.07%
==========================================
Files 141 142 +1
Lines 15722 15872 +150
==========================================
+ Hits 15513 15673 +160
+ Misses 209 199 -10
Continue to review full report at Codecov.
|
|
Ran some tests to determine the best nan approach to go with. Jupyter notebook: |
thehomebrewnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to create a new issue to remove the extra checking that is in place in the primitive functions to handle a single nan value after Woodwork is updated to allow for a tuple of nans in a LatLong column?
|
@thehomebrewnerd Created the issue: |
tamargrey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!

Uh oh!
There was an error while loading. Please reload this page.