Skip to content

Add workflow to auto-approve latest and minimum dependency pull requests - #1818

Merged
gsheni merged 30 commits into
mainfrom
enable_auto_merge
Dec 28, 2021
Merged

Add workflow to auto-approve latest and minimum dependency pull requests#1818
gsheni merged 30 commits into
mainfrom
enable_auto_merge

Conversation

@gsheni

@gsheni gsheni commented Dec 28, 2021

Copy link
Copy Markdown
Contributor
  • Enabled auto-merge for minimum and latest dependency pull requests
  • Created workflow to auto-approve latest and minimum dependency pull requests
  • Use correct pull request GitHub Action (rather than our own fork, which we update from time to time).

@gsheni gsheni self-assigned this Dec 28, 2021
@gsheni
gsheni requested a review from a team December 28, 2021 02:10
@gsheni
gsheni marked this pull request as ready for review December 28, 2021 02:10
@codecov

codecov Bot commented Dec 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1818 (e9b2f86) into main (cba7126) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1818      +/-   ##
==========================================
+ Coverage   98.67%   98.73%   +0.06%     
==========================================
  Files         141      141              
  Lines       15722    15722              
==========================================
+ Hits        15513    15523      +10     
+ Misses        209      199      -10     
Impacted Files Coverage Δ
featuretools/tests/conftest.py 100.00% <0.00%> (+0.40%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.45% <0.00%> (+0.65%) ⬆️
...computational_backends/calculate_feature_matrix.py 99.15% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba7126...e9b2f86. Read the comment docs.

Comment thread .github/workflows/latest_dependency_checker.yml
@gsheni
gsheni enabled auto-merge (squash) December 28, 2021 17:03
@gsheni
gsheni disabled auto-merge December 28, 2021 17:07
@tamargrey

tamargrey commented Dec 28, 2021

Copy link
Copy Markdown
Contributor

Nitpick - The file name auto_approve_dependency_MRs.yml should probably have PR for github throughout (unless its relying on some external thing with Mr, of course)

@gsheni gsheni changed the title Update latest dependency check to auto merge MR Update latest dependency check to auto merge PR Dec 28, 2021
@gsheni gsheni changed the title Update latest dependency check to auto merge PR Update latest and minimum dependency pull requests to auto merge Dec 28, 2021
@gsheni

gsheni commented Dec 28, 2021

Copy link
Copy Markdown
Contributor Author

@tamargrey renamed the file.

Comment thread .github/workflows/auto_approve_dependency_PRs.yml Outdated
@gsheni
gsheni enabled auto-merge (squash) December 28, 2021 17:35

@tamargrey tamargrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gsheni gsheni changed the title Update latest and minimum dependency pull requests to auto merge Add workflow to auto-approve latest and minimum dependency pull requests Dec 28, 2021
@gsheni
gsheni disabled auto-merge December 28, 2021 18:24
@gsheni
gsheni merged commit 5c77dd2 into main Dec 28, 2021
@gsheni
gsheni deleted the enable_auto_merge branch December 28, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants