Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3 credentials test issue #1825

merged 3 commits into from
Jan 3, 2022

Fix s3 credentials test issue #1825

merged 3 commits into from
Jan 3, 2022


Copy link

@rwedge rwedge commented Jan 3, 2022

Some unit tests were failing to download public files if existing AWS credentials were detected

This PR shifts testing S3 deserializing with credentials to only in tests with mocked S3 fixtures, leaving the real S3 tests that do not use credentials

@gsheni gsheni requested a review from a team January 3, 2022 22:49
Copy link

@davesque davesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with that test suite but LGTM!

@rwedge rwedge enabled auto-merge (squash) January 3, 2022 22:58
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #1825 (5836c90) into main (d13ae5e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1825      +/-   ##
+ Coverage   98.68%   98.74%   +0.06%     
  Files         142      142              
  Lines       15863    15841      -22     
- Hits        15654    15642      -12     
+ Misses        209      199      -10     
Impacted Files Coverage Δ
...etools/tests/entityset_tests/ 99.67% <100.00%> (-0.03%) ⬇️
...ests/primitive_tests/ 99.35% <100.00%> (ø)
featuretools/tests/ 100.00% <0.00%> (+0.40%) ⬆️
...utational_backend/ 99.45% <0.00%> (+0.65%) ⬆️
...computational_backends/ 99.15% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13ae5e...5836c90. Read the comment docs.

@rwedge rwedge merged commit 921f7fe into main Jan 3, 2022
@rwedge rwedge deleted the fix-s3-credentials-test-issue branch June 16, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants