Skip to content

Increase minimum numpy to 1.21.0 and remove fastparquet - #1833

Merged
gsheni merged 20 commits into
mainfrom
bump_numpy
Jan 7, 2022
Merged

Increase minimum numpy to 1.21.0 and remove fastparquet#1833
gsheni merged 20 commits into
mainfrom
bump_numpy

Conversation

@gsheni

@gsheni gsheni commented Jan 7, 2022

Copy link
Copy Markdown
Contributor
  • Removed fastparquet, as it cannot handle nullable pandas dtypes.
  • Removed pyyaml, as it will be handled by dask
  • Bump minimum numpy to 1.21.0
  • Bump minimum koalas to 1.8.1 (due to more recent numpy req)
  • Bump minimum scipy to 1.3.3 (due to more recent numpy req)

@gsheni gsheni self-assigned this Jan 7, 2022
@gsheni gsheni changed the title Update requirements.txt Increase minimum numpy to 1.21.0 Jan 7, 2022
@gsheni
gsheni requested a review from rwedge January 7, 2022 16:32
@gsheni
gsheni marked this pull request as ready for review January 7, 2022 16:33
@codecov

codecov Bot commented Jan 7, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1833 (febfaee) into main (808783a) will not change coverage.
The diff coverage is n/a.

❗ Current head febfaee differs from pull request most recent head dac6629. Consider uploading reports for the commit dac6629 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1833   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         142      142           
  Lines       15850    15850           
=======================================
  Hits        15659    15659           
  Misses        191      191           
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 99.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808783a...dac6629. Read the comment docs.

@gsheni
gsheni enabled auto-merge (squash) January 7, 2022 16:56
@gsheni
gsheni disabled auto-merge January 7, 2022 17:10
@gsheni gsheni changed the title Increase minimum numpy to 1.21.0 Increase minimum numpy to 1.21.0 and remove fastparquet Jan 7, 2022
@gsheni
gsheni requested a review from thehomebrewnerd January 7, 2022 19:05
@gsheni
gsheni enabled auto-merge (squash) January 7, 2022 19:12
Comment thread featuretools/tests/requirement_files/latest_requirements.txt Outdated
@rwedge

rwedge commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

Last time we updated PyYAML was due to a security vulnerability and dask does not set a min requirement, should we keep the requirement for now / suggest dask set a min requirement?

@gsheni

gsheni commented Jan 7, 2022

Copy link
Copy Markdown
Contributor Author

@rwedge If we are not using a dependency in our library, then its the other library's (dask) job to manage that dependency. Additionally, pip should just install the latest pyyaml by default (6.0).

I have created a dask issue:
dask/dask#8543

@rwedge

rwedge commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

Do we want to remove PyYAML from the show_info command?

deps = ["numpy", "pandas", "tqdm", "PyYAML", "cloudpickle",
"dask", "distributed", "psutil", "Click",
"pip", "setuptools"]

requirements = ["pandas", "numpy", "tqdm",
"pyyaml", "cloudpickle",
"dask", "distributed", "psutil",
"click"]

@gsheni

gsheni commented Jan 7, 2022

Copy link
Copy Markdown
Contributor Author

@rwedge good catch. Removed.

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni
gsheni merged commit 9cc0306 into main Jan 7, 2022
@gsheni
gsheni deleted the bump_numpy branch March 22, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants