-
Notifications
You must be signed in to change notification settings - Fork 894
Increase minimum numpy to 1.21.0 and remove fastparquet #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1833 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 142 142
Lines 15850 15850
=======================================
Hits 15659 15659
Misses 191 191
Continue to review full report at Codecov.
|
Last time we updated PyYAML was due to a security vulnerability and dask does not set a min requirement, should we keep the requirement for now / suggest dask set a min requirement? |
@rwedge If we are not using a dependency in our library, then its the other library's (dask) job to manage that dependency. Additionally, pip should just install the latest pyyaml by default (6.0). I have created a dask issue: |
Do we want to remove PyYAML from the featuretools/featuretools/utils/cli_utils.py Lines 12 to 14 in 9814869
featuretools/featuretools/tests/utils_tests/test_cli_utils.py Lines 32 to 35 in 9814869
|
@rwedge good catch. Removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fastparquet
, as it cannot handle nullable pandas dtypes.pyyaml
, as it will be handled by dask