Skip to content

Update auto approve dependency PR to run on workflow completion#1837

Merged
gsheni merged 4 commits intomainfrom
add_additional_condition_auto
Jan 10, 2022
Merged

Update auto approve dependency PR to run on workflow completion#1837
gsheni merged 4 commits intomainfrom
add_additional_condition_auto

Conversation

@gsheni
Copy link
Copy Markdown
Contributor

@gsheni gsheni commented Jan 7, 2022

  • This will make it so that when a workflow (unit tests) completes on a branch, the auto approve workflow will run.

@gsheni gsheni self-assigned this Jan 7, 2022
Comment thread .github/workflows/auto_approve_dependency_PRs.yml
workflow_run:
workflows: ["Unit Tests - Latest Dependencies"]
branches:
- 'latest-dep-update-[a-f0-9]+'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a double check on this syntax

dep_update = '^latest-dep-update-[a-f0-9]{7}$'
min_dep_update = '^min-dep-update-[a-f0-9]{7}$'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the github syntax supports [a-f0-9]{7} but we could put [a-f0-9] 7 times in a row . . .

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I put +, which means +: Matches one or more of the preceding character..

@gsheni gsheni marked this pull request as ready for review January 7, 2022 22:15
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@d59e110). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1837   +/-   ##
=======================================
  Coverage        ?   98.79%           
=======================================
  Files           ?      142           
  Lines           ?    15850           
  Branches        ?        0           
=======================================
  Hits            ?    15659           
  Misses          ?      191           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59e110...6b9674e. Read the comment docs.

@gsheni gsheni enabled auto-merge (squash) January 10, 2022 14:50
@gsheni gsheni requested review from rwedge and removed request for rwedge January 10, 2022 14:50
Copy link
Copy Markdown
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni merged commit d0256b3 into main Jan 10, 2022
@rwedge rwedge deleted the add_additional_condition_auto branch January 10, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants