Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated pandas workaround code in feature_set_calculator.py #1906

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Remove outdated pandas workaround code in feature_set_calculator.py

Closes #1711

The pandas issue that caused the code to be added appears to be resolved in more recent pandas releases, so this code is no longer necessary. See #1711 for more details.

@gsheni
Copy link
Contributor

gsheni commented Feb 14, 2022

@thehomebrewnerd Will you need to bump up the min pandas version?

@thehomebrewnerd
Copy link
Contributor Author

thehomebrewnerd commented Feb 14, 2022

@thehomebrewnerd Will you need to bump up the min pandas version?

No, this was fixed prior to pandas 1.3.0 which is our current min version.

@thehomebrewnerd thehomebrewnerd requested a review from a team February 14, 2022 21:28
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1906 (efe4848) into main (e86c353) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1906      +/-   ##
==========================================
+ Coverage   98.68%   98.77%   +0.09%     
==========================================
  Files         148      148              
  Lines       16355    16352       -3     
==========================================
+ Hits        16140    16152      +12     
+ Misses        215      200      -15     
Impacted Files Coverage Δ
...s/computational_backends/feature_set_calculator.py 98.69% <ø> (+0.24%) ⬆️
...computational_backends/calculate_feature_matrix.py 100.00% <0.00%> (+0.83%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 100.00% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86c353...efe4848. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thehomebrewnerd thehomebrewnerd merged commit da50d32 into main Feb 16, 2022
@thehomebrewnerd thehomebrewnerd deleted the issue-1711 branch February 16, 2022 13:51
@jeff-hernandez jeff-hernandez mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review/remove old code from feature_set_calculator.py
3 participants