Remove outdated pandas workaround code in feature_set_calculator.py#1906
Merged
thehomebrewnerd merged 3 commits intomainfrom Feb 16, 2022
Merged
Remove outdated pandas workaround code in feature_set_calculator.py#1906thehomebrewnerd merged 3 commits intomainfrom
thehomebrewnerd merged 3 commits intomainfrom
Conversation
Contributor
|
@thehomebrewnerd Will you need to bump up the min pandas version? |
Contributor
Author
No, this was fixed prior to pandas 1.3.0 which is our current min version. |
Codecov Report
@@ Coverage Diff @@
## main #1906 +/- ##
==========================================
+ Coverage 98.68% 98.77% +0.09%
==========================================
Files 148 148
Lines 16355 16352 -3
==========================================
+ Hits 16140 16152 +12
+ Misses 215 200 -15
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove outdated pandas workaround code in feature_set_calculator.py
Closes #1711
The pandas issue that caused the code to be added appears to be resolved in more recent pandas releases, so this code is no longer necessary. See #1711 for more details.