Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new holidays library error #1907

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Update for new holidays library error #1907

merged 2 commits into from
Feb 16, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd commented Feb 16, 2022

Update for new holidays library error

Updates the Featuretools HolidayUtil class to catch a NotImplementedError in addition to the previous KeyError. Version 0.13.0 of holidays will now raise a NotImplementedError if an unknown country is provided instead of the previous KeyError. Catching both errors will allow for compatibility with the new version as well as older versions.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1907 (1b36b7e) into main (e86c353) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1907      +/-   ##
==========================================
+ Coverage   98.68%   98.77%   +0.09%     
==========================================
  Files         148      148              
  Lines       16355    16352       -3     
==========================================
+ Hits        16140    16152      +12     
+ Misses        215      200      -15     
Impacted Files Coverage Δ
...s/computational_backends/feature_set_calculator.py 98.69% <ø> (+0.24%) ⬆️
featuretools/primitives/utils.py 99.51% <100.00%> (ø)
...computational_backends/calculate_feature_matrix.py 100.00% <0.00%> (+0.83%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 100.00% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da50d32...1b36b7e. Read the comment docs.

@thehomebrewnerd thehomebrewnerd requested a review from a team February 16, 2022 15:44
@thehomebrewnerd thehomebrewnerd merged commit 6dd46f4 into main Feb 16, 2022
@thehomebrewnerd thehomebrewnerd deleted the holidays-fix branch February 16, 2022 15:46
@jeff-hernandez jeff-hernandez mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants