Skip to content

Update urls to test deserialization#1909

Merged
rwedge merged 2 commits into
mainfrom
new-serialization-url
Feb 16, 2022
Merged

Update urls to test deserialization#1909
rwedge merged 2 commits into
mainfrom
new-serialization-url

Conversation

@rwedge

@rwedge rwedge commented Feb 16, 2022

Copy link
Copy Markdown
Contributor

The newest woodwork version handles LatLong nans slightly differently and requires a new file in order to deserialize to the same entityset as the tests expect. This new file will work with older version of woodwork as well.

@codecov

codecov Bot commented Feb 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1909 (3f6f90b) into main (6dd46f4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1909   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         148      148           
  Lines       16352    16352           
=======================================
  Hits        16152    16152           
  Misses        200      200           
Impacted Files Coverage Δ
...etools/tests/entityset_tests/test_serialization.py 99.67% <100.00%> (ø)
...ests/primitive_tests/test_feature_serialization.py 99.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dd46f4...3f6f90b. Read the comment docs.

@rwedge rwedge changed the title Update urls to test deseiralization Update urls to test deserialization Feb 16, 2022

@thehomebrewnerd thehomebrewnerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rwedge rwedge merged commit d451523 into main Feb 16, 2022
@rwedge rwedge deleted the new-serialization-url branch February 16, 2022 22:41
@jeff-hernandez jeff-hernandez mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants