Add IsFederalHoliday transform primitive - #1912
Merged
Merged
Conversation
jeff-hernandez
commented
Feb 17, 2022
| self.country = country | ||
| try: | ||
| self.holidays = holidays.CountryHoliday(self.country) | ||
| except (KeyError, NotImplementedError): |
Contributor
Author
There was a problem hiding this comment.
holidays version 0.13 now raises NotImplementedError instead of KeyError
jeff-hernandez
marked this pull request as ready for review
February 17, 2022 18:48
gsheni
reviewed
Feb 17, 2022
rwedge
reviewed
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #1912 +/- ##
=======================================
Coverage 98.77% 98.78%
=======================================
Files 148 149 +1
Lines 16352 16424 +72
=======================================
+ Hits 16152 16224 +72
Misses 200 200
Continue to review full report at Codecov.
|
jeff-hernandez
commented
Feb 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1869