Skip to content

Add IsFederalHoliday transform primitive #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 17, 2022
Merged

Add IsFederalHoliday transform primitive #1912

merged 13 commits into from
Feb 17, 2022

Conversation

jeff-hernandez
Copy link
Contributor

Closes #1869

jeff-hernandez
jeff-hernandez commented Feb 17, 2022
View reviewed changes
featuretools/primitives/standard/datetime_transform_primitives.py Outdated
self.country = country
try:
self.holidays = holidays.CountryHoliday(self.country)
except (KeyError, NotImplementedError):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holidays version 0.13 now raises NotImplementedError instead of KeyError

@jeff-hernandez jeff-hernandez marked this pull request as ready for review February 17, 2022 18:48
@jeff-hernandez jeff-hernandez requested review from rwedge and a team February 17, 2022 18:50
gsheni
gsheni reviewed Feb 17, 2022
View reviewed changes
rwedge
rwedge reviewed Feb 17, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited
Loading

Codecov Report

Merging #1912 (c924b55) into main (83d67ee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1912   +/-   ##
=======================================
  Coverage   98.77%   98.78%           
=======================================
  Files         148      149    +1     
  Lines       16352    16424   +72     
=======================================
+ Hits        16152    16224   +72     
  Misses        200      200
Impacted Files Coverage Δ
...imitives/standard/datetime_transform_primitives.py 100.00% <100.00%> (ø)
featuretools/primitives/utils.py 99.51% <100.00%> (ø)
...s/tests/primitive_tests/test_is_federal_holiday.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d67ee...c924b55. Read the comment docs.

jeff-hernandez
jeff-hernandez commented Feb 17, 2022
View reviewed changes
rwedge
rwedge approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeff-hernandez jeff-hernandez merged commit 1fd1833 into main Feb 17, 2022
@jeff-hernandez jeff-hernandez deleted the is_federal_holiday branch February 17, 2022 20:17
@jeff-hernandez jeff-hernandez mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni left review comments

@rwedge rwedge rwedge approved these changes

@thehomebrewnerd thehomebrewnerd Awaiting requested review from thehomebrewnerd

Assignees

@jeff-hernandez jeff-hernandez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IsFederalHoliday transform primitive
4 participants
@jeff-hernandez @thehomebrewnerd @rwedge @gsheni