-
Notifications
You must be signed in to change notification settings - Fork 902
Updated the conda install commands to specify the channel #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kushal-gopal thanks for putting up the PR. In order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request number with a short description. Be sure to add your name. Here is an example of how to do this (from another PR): |
Codecov Report
@@ Coverage Diff @@
## main #1917 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 149 149
Lines 16424 16424
=======================================
Hits 16224 16224
Misses 200 200
Continue to review full report at Codecov.
|
Thanks for reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
@kushal-gopal Thanks! Congrats on your first contribution to Featuretools! |
Fixes #1718
Updated utils/s3_utils.py file by specifying the channel for the three error messages - BOTO3_ERR_MSG, BOTOCORE_ERR_MSG, SMART_OPEN_ERR_MSG.
One thing which requires review is that I found package name for smart-open in conda-forge to be smart_open.
https://anaconda.org/conda-forge/smart_open