Skip to content

Updated the conda install commands to specify the channel #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 28, 2022

Conversation

kushal-gopal
Copy link
Contributor

@kushal-gopal kushal-gopal commented Feb 18, 2022

Fixes #1718

Updated utils/s3_utils.py file by specifying the channel for the three error messages - BOTO3_ERR_MSG, BOTOCORE_ERR_MSG, SMART_OPEN_ERR_MSG.

One thing which requires review is that I found package name for smart-open in conda-forge to be smart_open.
https://anaconda.org/conda-forge/smart_open

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2022

CLA assistant check
All committers have signed the CLA.

@gsheni
Copy link
Contributor

gsheni commented Feb 18, 2022

@kushal-gopal thanks for putting up the PR.

In order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request number with a short description. Be sure to add your name.

Here is an example of how to do this (from another PR):

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1917 (304b674) into main (4bb243b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1917   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files         149      149           
  Lines       16424    16424           
=======================================
  Hits        16224    16224           
  Misses        200      200           
Impacted Files Coverage Δ
featuretools/utils/s3_utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb243b...304b674. Read the comment docs.

@kushal-gopal
Copy link
Contributor Author

@gsheni,

Thanks for reviewing.
I did update the docs/source/release_notes.rst file and please let me know if I need to do anything more.
Thanks again for this opportunity as this is my first open source contribution. So yayy!

gsheni
gsheni previously approved these changes Feb 28, 2022
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@gsheni gsheni enabled auto-merge (squash) February 28, 2022 17:20
@gsheni gsheni merged commit 49d0e67 into alteryx:main Feb 28, 2022
@gsheni
Copy link
Contributor

gsheni commented Feb 28, 2022

@kushal-gopal Thanks! Congrats on your first contribution to Featuretools!

@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update conda install commands to specify channel
3 participants