Skip to content

Better error when DFS returns an empty list of features - #1919

Merged
mingdavidqi merged 15 commits into
mainfrom
update_dfs_error_message
Mar 1, 2022
Merged

mingdavidqi merged 15 commits into
mainfrom
update_dfs_error_message

Conversation

@DavidQi

@DavidQi DavidQi commented Feb 18, 2022 •

Copy link
Copy Markdown
Contributor

@CLAassistant

CLAassistant commented Feb 18, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Feb 18, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #1919 (128be18) into main (5974359) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1919   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files         149      149           
  Lines       16424    16438   +14     
=======================================
+ Hits        16224    16238   +14     
  Misses        200      200           
Impacted Files Coverage Δ
featuretools/synthesis/dfs.py 100.00% <100.00%> (ø)
featuretools/tests/synthesis/test_dfs_method.py 99.56% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5974359...128be18. Read the comment docs.

@gsheni gsheni changed the title update dfs error message when an empty list returned. issue #1309 Bbetter error when DFS returns an empty list of features Feb 18, 2022
@gsheni gsheni changed the title Bbetter error when DFS returns an empty list of features Better error when DFS returns an empty list of features Feb 18, 2022
@DavidQi
DavidQi requested review from a team and rwedge and removed request for rwedge February 21, 2022 13:49
Comment thread featuretools/synthesis/dfs.py Resolved
Comment thread featuretools/synthesis/dfs.py Resolved

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Congrats on your first contribution to Featuretools!

@mingdavidqi
mingdavidqi merged commit af8d490 into main Mar 1, 2022
@mingdavidqi
mingdavidqi deleted the update_dfs_error_message branch March 2, 2022 20:49
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raise better error when DFS returns an empty list of features

5 participants