Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize LatLong NaN values during EntitySet creation #1924

Merged
merged 43 commits into from
Apr 1, 2022

Conversation

dvreed77
Copy link
Contributor

@dvreed77 dvreed77 commented Feb 28, 2022

Normalize LatLong NaN values during EntitySet creation

Fixes #1819 and #1820

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1924 (7da2c5c) into main (7f6deec) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1924      +/-   ##
==========================================
+ Coverage   98.97%   99.00%   +0.02%     
==========================================
  Files         143      143              
  Lines       16369    16422      +53     
==========================================
+ Hits        16201    16258      +57     
+ Misses        168      164       -4     
Impacted Files Coverage Δ
featuretools/primitives/utils.py 99.50% <ø> (-0.01%) ⬇️
featuretools/entityset/entityset.py 99.10% <100.00%> (+0.01%) ⬆️
...rimitives/standard/latlong_transform_primitives.py 100.00% <100.00%> (+1.02%) ⬆️
featuretools/tests/conftest.py 100.00% <100.00%> (ø)
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)
...s/tests/primitive_tests/test_latlong_primitives.py 100.00% <100.00%> (ø)
featuretools/utils/spark_utils.py 100.00% <100.00%> (ø)
...computational_backends/calculate_feature_matrix.py 99.16% <0.00%> (-0.84%) ⬇️
...utational_backend/test_calculate_feature_matrix.py 98.80% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6deec...7da2c5c. Read the comment docs.

@dvreed77 dvreed77 marked this pull request as ready for review March 29, 2022 21:33
@dvreed77 dvreed77 requested review from thehomebrewnerd and rwedge and removed request for thehomebrewnerd March 29, 2022 21:33
featuretools/entityset/entityset.py Outdated Show resolved Hide resolved
featuretools/entityset/entityset.py Outdated Show resolved Hide resolved
featuretools/tests/entityset_tests/test_es.py Outdated Show resolved Hide resolved
featuretools/tests/entityset_tests/test_es.py Outdated Show resolved Hide resolved
featuretools/entityset/entityset.py Outdated Show resolved Hide resolved
featuretools/tests/entityset_tests/test_es.py Outdated Show resolved Hide resolved
featuretools/tests/entityset_tests/test_es.py Outdated Show resolved Hide resolved
featuretools/entityset/entityset.py Outdated Show resolved Hide resolved
featuretools/tests/entityset_tests/test_es.py Show resolved Hide resolved
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once all the tests pass!

@dvreed77 dvreed77 enabled auto-merge (squash) April 1, 2022 19:59
@dvreed77 dvreed77 merged commit ae10ab5 into main Apr 1, 2022
@dvreed77 dvreed77 deleted the iss-1819-convert-latlong-nans branch April 1, 2022 20:19
@thehomebrewnerd thehomebrewnerd mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change LatLong values from NaN to tuple of NaNs during EntitySet creation
4 participants