Update test cases to cover main.py file - #1927
Merged
Merged
Conversation
Contributor
|
@mingdavidqi I just realized something. I think you might just need to add an Not completely sure this is it, but maybe something to look into. |
Codecov Report
@@ Coverage Diff @@
## main #1927 +/- ##
==========================================
+ Coverage 98.78% 98.99% +0.21%
==========================================
Files 149 150 +1
Lines 16438 16456 +18
==========================================
+ Hits 16238 16291 +53
+ Misses 200 165 -35
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASAIK, pytest normally avoids main.py files because the name main.py doesn't match the test_*.py or *_test.py patterns wich pytest is looking for.
No idea why it's covered (42.86%) before and why it's gone now.
Tried to write some test cases to cover main.py file and updated codecov-action @ v2 beacause of https://github.com/marketplace/actions/codecov
Fixes #1885