Conversation
Codecov Report
@@ Coverage Diff @@
## main #1929 +/- ##
==========================================
- Coverage 98.99% 98.99% -0.01%
==========================================
Files 150 146 -4
Lines 16456 16438 -18
==========================================
- Hits 16291 16273 -18
Misses 165 165
Continue to review full report at Codecov.
|
| composeml==0.8.0 | ||
| urllib3==1.26.5 | ||
| pyarrow==3.0.0 | ||
| responses<0.19.0 |
There was a problem hiding this comment.
@gsheni will adding a requirement to this file lead to any issues if the minimum dependency checker decides to update the file? Is it possible it would get overwritten if the dependency checker isn't tracking it?
There was a problem hiding this comment.
This is not the way to do this. You need to put responses>=0.X.X,<0.19.0 in the main requirements.txt/test-requirements.txt. Then in minimum_test_requirements.txt you need to put the lowest responses requirement.
There was a problem hiding this comment.
So the min responses version on the latest moto is 0.9.0 and it has been since moto v1.3.5 (our min version of moto). I'll make the changes to test-requirements and minimum_test_requirements.
Removes the deprecated utility
list_variable_types.Closes #1613