Skip to content

Remove list_variable_types utility#1929

Merged
tamargrey merged 5 commits intomainfrom
remove-list-variable-types
Mar 7, 2022
Merged

Remove list_variable_types utility#1929
tamargrey merged 5 commits intomainfrom
remove-list-variable-types

Conversation

@tamargrey
Copy link
Contributor

Removes the deprecated utility list_variable_types.

Closes #1613

@tamargrey tamargrey requested a review from rwedge March 7, 2022 15:04
rwedge
rwedge previously approved these changes Mar 7, 2022
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1929 (2eb2ca2) into main (068887e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1929      +/-   ##
==========================================
- Coverage   98.99%   98.99%   -0.01%     
==========================================
  Files         150      146       -4     
  Lines       16456    16438      -18     
==========================================
- Hits        16291    16273      -18     
  Misses        165      165              
Impacted Files Coverage Δ
featuretools/__init__.py 73.33% <ø> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 068887e...2eb2ca2. Read the comment docs.

composeml==0.8.0
urllib3==1.26.5
pyarrow==3.0.0
responses<0.19.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsheni will adding a requirement to this file lead to any issues if the minimum dependency checker decides to update the file? Is it possible it would get overwritten if the dependency checker isn't tracking it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the way to do this. You need to put responses>=0.X.X,<0.19.0 in the main requirements.txt/test-requirements.txt. Then in minimum_test_requirements.txt you need to put the lowest responses requirement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the min responses version on the latest moto is 0.9.0 and it has been since moto v1.3.5 (our min version of moto). I'll make the changes to test-requirements and minimum_test_requirements.

@tamargrey tamargrey merged commit b46ad7b into main Mar 7, 2022
@tamargrey tamargrey deleted the remove-list-variable-types branch March 7, 2022 20:20
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove list_variable_types util function

3 participants