Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow to run unit tests with latest from Woodwork main #1936

Merged
merged 14 commits into from
Mar 11, 2022

Conversation

mingdavidqi
Copy link
Contributor

@mingdavidqi mingdavidqi commented Mar 8, 2022

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1936 (e7859f3) into main (3937593) will not change coverage.
The diff coverage is n/a.

❗ Current head e7859f3 differs from pull request most recent head 46990f4. Consider uploading reports for the commit 46990f4 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1936   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         146      146           
  Lines       16438    16438           
=======================================
  Hits        16273    16273           
  Misses        165      165           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71894e5...46990f4. Read the comment docs.

@mingdavidqi mingdavidqi requested review from a team and removed request for a team March 8, 2022 17:19
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, but also have a question about the intended behavior here.

@gsheni Are we expecting this series of checks to run as part of every new PR to Featuretools or do we want this to be a scheduled run that periodically runs the test suite with WW main and alerts us on a failure?

.github/workflows/test_with_woodwork_main_branch.yml Outdated Show resolved Hide resolved
docs/source/release_notes.rst Outdated Show resolved Hide resolved
koalas-requirements.txt Outdated Show resolved Hide resolved
.github/workflows/test_with_woodwork_main_branch.yml Outdated Show resolved Hide resolved
@gsheni gsheni changed the title Schedule test ww main Add CI workflow to run unit tests with latest from Woodwork main Mar 8, 2022
name: Test Featuretools with Woodwork main Branch
on:
schedule:
- cron: "0 * * * *"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this be excessive?
@rwedge Should we lower this or come up with another trigger?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsheni if we fix the issue with https://github.com/alteryx/gh-action-ci we could have it only actually run if there's been a recent commit

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rwedge rwedge enabled auto-merge (squash) March 11, 2022 23:36
@rwedge rwedge merged commit f0ead62 into main Mar 11, 2022
@mingdavidqi mingdavidqi deleted the schedule_test_ww_main branch March 11, 2022 23:48
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI workflow to run unit tests with latest from Woodwork main
4 participants