-
Notifications
You must be signed in to change notification settings - Fork 907
Add CI workflow to run unit tests with latest from Woodwork main #1936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1936 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 146 146
Lines 16438 16438
=======================================
Hits 16273 16273
Misses 165 165 Continue to review full report at Codecov.
|
thehomebrewnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, but also have a question about the intended behavior here.
@gsheni Are we expecting this series of checks to run as part of every new PR to Featuretools or do we want this to be a scheduled run that periodically runs the test suite with WW main and alerts us on a failure?
| name: Test Featuretools with Woodwork main Branch | ||
| on: | ||
| schedule: | ||
| - cron: "0 * * * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this be excessive?
@rwedge Should we lower this or come up with another trigger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsheni if we fix the issue with https://github.com/alteryx/gh-action-ci we could have it only actually run if there's been a recent commit
rwedge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Uh oh!
There was an error while loading. Please reload this page.