Skip to content

Transition to pyproject.toml and setup.cfg#1941

Merged
thehomebrewnerd merged 21 commits into
mainfrom
pyprojecttoml
Mar 10, 2022
Merged

Transition to pyproject.toml and setup.cfg#1941
thehomebrewnerd merged 21 commits into
mainfrom
pyprojecttoml

Conversation

@thehomebrewnerd
Copy link
Copy Markdown
Contributor

Transition to pyproject.toml and setup.cfg

Closes #1921

@gsheni
Copy link
Copy Markdown
Contributor

gsheni commented Mar 9, 2022

Let's update our install test to run on on mac and ubuntu

name: Install Test
jobs:
  install_ft_complete:
    name: ${{ matrix.os }} - ${{ matrix.python_version }} install featuretools
    strategy:
      fail-fast: false
      matrix:
        python_version: ["3.8", "3.9"]
        os: [ubuntu-latest, macos-latest]

Comment thread setup.cfg
@alteryx alteryx deleted a comment from thehomebrewnerd Mar 9, 2022
@gsheni
Copy link
Copy Markdown
Contributor

gsheni commented Mar 9, 2022

One thing I forgot, the minimum_dependency_checker.yml file can be updated with v3.1

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2022

Codecov Report

Merging #1941 (b2067c4) into main (c5ad964) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1941   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         146      146           
  Lines       16438    16438           
=======================================
  Hits        16273    16273           
  Misses        165      165           
Impacted Files Coverage Δ
featuretools/__init__.py 73.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5ad964...b2067c4. Read the comment docs.

gsheni
gsheni previously approved these changes Mar 10, 2022
Copy link
Copy Markdown
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread .github/workflows/minimum_dependency_checker.yml
Copy link
Copy Markdown
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Installing in editable mode allowed you to get complete code coverage

@thehomebrewnerd
Copy link
Copy Markdown
Contributor Author

Interesting. Installing in editable mode allowed you to get complete code coverage

Yeah, don't fully understand the reason, but that was one difference I noticed as I reviewed the install commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transition Featuretools to use pyproject.toml and setup.cfg (moving away from setup.py)

3 participants