-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to pyproject.toml and setup.cfg #1941
Conversation
Let's update our install test to run on on mac and ubuntu
|
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
One thing I forgot, the |
Codecov Report
@@ Coverage Diff @@
## main #1941 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 146 146
Lines 16438 16438
=======================================
Hits 16273 16273
Misses 165 165
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Installing in editable mode allowed you to get complete code coverage
Yeah, don't fully understand the reason, but that was one difference I noticed as I reviewed the install commands. |
Transition to pyproject.toml and setup.cfg
Closes #1921