Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile command for zsh compatibility #1957

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Conversation

thehomebrewnerd
Copy link
Contributor

Update pip install -e .[dev] to pip install -e ".[dev]" so that make installdeps will work with zsh.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1957 (b6fb314) into main (61876c8) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
+ Coverage   98.87%   98.99%   +0.12%     
==========================================
  Files         146      146              
  Lines       16478    16478              
==========================================
+ Hits        16292    16313      +21     
+ Misses        186      165      -21     
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 100.00% <0.00%> (+0.83%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 100.00% <0.00%> (+1.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61876c8...b6fb314. Read the comment docs.

@thehomebrewnerd thehomebrewnerd merged commit 55cb2be into main Mar 15, 2022
@thehomebrewnerd thehomebrewnerd deleted the makefile-cmds branch March 15, 2022 14:57
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants