Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-deterministic test in test_es.py #1961

Merged
merged 3 commits into from Mar 15, 2022
Merged

Fix non-deterministic test in test_es.py #1961

merged 3 commits into from Mar 15, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Fix non-deterministic test in test_es.py. Failure showed up after switching from Koalas to the pyspark pandas API and failed because rows were returned in a different order with spark.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1961 (8577a0f) into main (a166152) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1961      +/-   ##
==========================================
- Coverage   98.99%   98.90%   -0.09%     
==========================================
  Files         146      146              
  Lines       16477    16477              
==========================================
- Hits        16311    16297      -14     
- Misses        166      180      +14     
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)
...utational_backend/test_calculate_feature_matrix.py 98.80% <0.00%> (-1.20%) ⬇️
...computational_backends/calculate_feature_matrix.py 99.16% <0.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a166152...8577a0f. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thehomebrewnerd thehomebrewnerd merged commit 3af5131 into main Mar 15, 2022
@thehomebrewnerd thehomebrewnerd deleted the test-failure branch March 15, 2022 19:46
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants