Remove make_trans_primitive and make_agg_primitive functions

[thehomebrewnerd]

Remove make_trans_primitive and make_agg_primitive functions

Closes #1953

[codecov]

Codecov Report

Merging #1970 (579d3e8) into main (e565ec9) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
+ Coverage   98.99%   99.08%   +0.09%     
==========================================
  Files         146      143       -3     
  Lines       16477    16369     -108     
==========================================
- Hits        16311    16219      -92     
+ Misses        166      150      -16     

Impacted Files	Coverage Δ
featuretools/feature_base/feature_base.py	96.88% <ø> (ø)
featuretools/primitives/api.py	100.00% <ø> (ø)
...ools/primitives/base/aggregation_primitive_base.py	100.00% <ø> (ø)
...etools/primitives/base/transform_primitive_base.py	100.00% <ø> (ø)
featuretools/primitives/base/api.py	100.00% <100.00%> (ø)
featuretools/primitives/base/primitive_base.py	96.25% <100.00%> (-0.10%)	⬇️
...e_tests/bad_primitive_files/multiple_primitives.py	100.00% <100.00%> (ø)
...rimitive_tests/primitives_to_install/custom_max.py	100.00% <100.00%> (ø)
...imitive_tests/primitives_to_install/custom_mean.py	100.00% <100.00%> (ø)
...rimitive_tests/primitives_to_install/custom_sum.py	100.00% <100.00%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e565ec9...579d3e8. Read the comment docs.

[thehomebrewnerd]

Changing from make_trans_primitive and make_agg_primitive function to defining custom classes resulted in several new uncovered lines of code. This seems to be because many of the primitives that were defined using these functions were only tested in DFS and were never used in calculate feature matrix so many of the primitive functions are not being called.

We have a few options for this - I'm not sure what's best:

1. Leave everything as is with the uncovered new lines
2. Remove the unused primitive functions
3. Mark these primitive functions with # pragma: no cover and leave in place

[rwedge]

featuretools/featuretools/primitives/base/primitive_base.py

Lines 85 to 92 in ff67dd3

	def get_arguments(self):
	values = []
	args = signature(self.__class__).parameters.items()
	for name, arg in args:
	# skip if not a standard argument (e.g. excluding *args and **kwargs)
	if arg.kind != arg.POSITIONAL_OR_KEYWORD:
	continue

the continue line is no longer getting covered

[thehomebrewnerd]

featuretools/featuretools/primitives/base/primitive_base.py

Lines 85 to 92 in ff67dd3

	def get_arguments(self):
	values = []
	args = signature(self.__class__).parameters.items()
	for name, arg in args:
	# skip if not a standard argument (e.g. excluding *args and **kwargs)
	if arg.kind != arg.POSITIONAL_OR_KEYWORD:
	continue

the continue line is no longer getting covered

Went ahead and removed this if block that was not getting covered. It was previously getting hit by the test test_time_since_last_custom in test_agg_feats.py. Seems that this was perhaps required as a results of the way make_agg_primitive worked, as it no longer gets hit by the updated test.

[tamargrey]

lgtm!