Skip to content

Fix minimum dependency version tag #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gsheni merged 3 commits into from
Mar 22, 2022
Merged

Fix minimum dependency version tag #1976

gsheni merged 3 commits into from
Mar 22, 2022

Conversation

@gsheni
Copy link
Contributor

@gsheni gsheni commented Mar 22, 2022 •
edited
Loading

  • Used 3.2 instead of v3.2

@gsheni gsheni changed the title Update minimum_dependency_checker.yml Fix minimum dependency version tag Mar 22, 2022
@gsheni gsheni self-assigned this Mar 22, 2022
@gsheni gsheni requested a review from freddyaboulton March 22, 2022 20:33
@gsheni gsheni marked this pull request as ready for review March 22, 2022 20:33
@gsheni gsheni enabled auto-merge (squash) March 22, 2022 20:44
@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #1976 (5a937b9) into main (4102ae6) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   98.88%   98.99%   +0.10%     
==========================================
  Files         146      146              
  Lines       16477    16477              
==========================================
+ Hits        16294    16311      +17     
+ Misses        183      166      -17
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 100.00% <0.00%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4102ae6...5a937b9. Read the comment docs.

@gsheni gsheni merged commit e565ec9 into main Mar 22, 2022
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 31, 2022
Merged
@gsheni gsheni deleted the fix_version_min_dep branch May 19, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@freddyaboulton freddyaboulton freddyaboulton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gsheni gsheni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsheni @freddyaboulton