Skip to content

Add black linting package and remove autopep8#1978

Merged
gsheni merged 6 commits intomainfrom
add-black
Mar 28, 2022
Merged

Add black linting package and remove autopep8#1978
gsheni merged 6 commits intomainfrom
add-black

Conversation

@thehomebrewnerd
Copy link
Copy Markdown
Contributor

Add black linting package and remove autopep8

Closes #1883

@thehomebrewnerd thehomebrewnerd requested a review from a team March 23, 2022 20:54
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@642bd62). Click here to learn what that means.
The diff coverage is 98.85%.

@@           Coverage Diff           @@
##             main    #1978   +/-   ##
=======================================
  Coverage        ?   99.07%           
=======================================
  Files           ?      143           
  Lines           ?    16369           
  Branches        ?        0           
=======================================
  Hits            ?    16218           
  Misses          ?      151           
  Partials        ?        0           
Impacted Files Coverage Δ
featuretools/exceptions.py 80.00% <ø> (ø)
featuretools/feature_base/api.py 100.00% <ø> (ø)
featuretools/primitives/api.py 100.00% <ø> (ø)
featuretools/synthesis/utils.py 100.00% <ø> (ø)
...utational_backend/test_calculate_feature_matrix.py 100.00% <ø> (ø)
featuretools/tests/entityset_tests/test_es.py 100.00% <ø> (ø)
...ools/tests/primitive_tests/test_direct_features.py 100.00% <ø> (ø)
...imitive_tests/test_distancetoholiday_primitives.py 100.00% <ø> (ø)
...retools/tests/primitive_tests/test_feature_base.py 100.00% <ø> (ø)
...tests/primitive_tests/test_feature_descriptions.py 100.00% <ø> (ø)
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 642bd62...8a64c70. Read the comment docs.

gsheni
gsheni previously approved these changes Mar 24, 2022
@gsheni gsheni enabled auto-merge (squash) March 24, 2022 14:29
@rwedge
Copy link
Copy Markdown
Contributor

rwedge commented Mar 24, 2022

module 'jinja2.utils' has no attribute 'escape'

@rwedge
Copy link
Copy Markdown
Contributor

rwedge commented Mar 24, 2022

module 'jinja2.utils' has no attribute 'escape'

Issue with a dependency, unrelated

Comment thread Makefile Outdated
@thehomebrewnerd thehomebrewnerd requested review from a team and gsheni March 28, 2022 16:38
Copy link
Copy Markdown
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Makefile changes look good and the rest look like formatting.

@gsheni gsheni merged commit f5e3f88 into main Mar 28, 2022
@thehomebrewnerd thehomebrewnerd deleted the add-black branch March 28, 2022 17:14
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add black linting package and remove autopep8 for Featuretools

4 participants