Skip to content

Update to fix broken tests and doc builds#1984

Merged
gsheni merged 7 commits intomainfrom
ww15-fix
Mar 28, 2022
Merged

Update to fix broken tests and doc builds#1984
gsheni merged 7 commits intomainfrom
ww15-fix

Conversation

@thehomebrewnerd
Copy link
Contributor

Update to fix broken tests and doc builds

Updates tests to accommodate new repr for Ordinal logical type introduced in Woodwork version 0.15.0.

Also, pins jinja2 version to fix docs build issue.

gsheni
gsheni previously approved these changes Mar 28, 2022
@thehomebrewnerd thehomebrewnerd enabled auto-merge (squash) March 28, 2022 15:09
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1984 (6ce379d) into main (596166c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6ce379d differs from pull request most recent head 6e416b9. Consider uploading reports for the commit 6e416b9 to get more accurate results

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
- Coverage   99.08%   99.07%   -0.01%     
==========================================
  Files         143      143              
  Lines       16369    16369              
==========================================
- Hits        16219    16218       -1     
- Misses        150      151       +1     
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)
...ools/tests/primitive_tests/test_primitive_utils.py 100.00% <100.00%> (ø)
featuretools/entityset/entityset.py 99.08% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596166c...6e416b9. Read the comment docs.

setup.cfg Outdated
nbsphinx == 0.8.7
pydata-sphinx-theme== 0.7.1
Sphinx == 4.2.0
jinja2 == 3.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jinja 2 is fixed, update nbconvert to 6.4.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed jinja2, updated nbconvert and fixed release notes entry

@gsheni gsheni disabled auto-merge March 28, 2022 15:22
@gsheni gsheni merged commit 642bd62 into main Mar 28, 2022
@gsheni gsheni deleted the ww15-fix branch March 28, 2022 15:59
@thehomebrewnerd thehomebrewnerd mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants