Skip to content

Update UnusedPrimitiveWarning text#2003

Merged
thehomebrewnerd merged 2 commits intomainfrom
multi-unused-prim
Mar 31, 2022
Merged

Update UnusedPrimitiveWarning text#2003
thehomebrewnerd merged 2 commits intomainfrom
multi-unused-prim

Conversation

@thehomebrewnerd
Copy link
Contributor

Update UnusedPrimitiveWarning text

Closes #1141

Add clarifying text to UnusedPrimitiveWarning to explain behavior if multiple instances of a primitive are unused.

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #2003 (8e3453c) into main (c682805) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
+ Coverage   98.99%   99.07%   +0.08%     
==========================================
  Files         143      143              
  Lines       16369    16369              
==========================================
+ Hits        16204    16218      +14     
+ Misses        165      151      -14     
Impacted Files Coverage Δ
featuretools/synthesis/dfs.py 100.00% <ø> (ø)
featuretools/tests/synthesis/test_dfs_method.py 100.00% <ø> (ø)
...computational_backends/calculate_feature_matrix.py 100.00% <0.00%> (+0.83%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 100.00% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c682805...8e3453c. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thehomebrewnerd thehomebrewnerd merged commit 8cfb2e7 into main Mar 31, 2022
@thehomebrewnerd thehomebrewnerd deleted the multi-unused-prim branch March 31, 2022 22:03
@thehomebrewnerd thehomebrewnerd mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catch multiple versions of a primitive, one unused

2 participants